Skip to content

Replace prohibited dashes with underscores on backup report plans #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace prohibited dashes with underscores on backup report plans #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/aws-backup-source/backup_report_plan.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Create the reports
resource "aws_backup_report_plan" "backup_jobs" {
name = "${local.resource_name_prefix}_backup_jobs"
name = replace("${local.resource_name_prefix}_backup_jobs", "-", "_")
description = "Report for showing whether backups ran successfully in the last 24 hours"

report_delivery_channel {
Expand All @@ -18,7 +18,7 @@ resource "aws_backup_report_plan" "backup_jobs" {

# Create the restore testing completion reports
resource "aws_backup_report_plan" "backup_restore_testing_jobs" {
name = "${local.resource_name_prefix}_backup_restore_testing_jobs"
name = replace("${local.resource_name_prefix}_backup_restore_testing_jobs", "-", "_")
description = "Report for showing whether backup restore test ran successfully in the last 24 hours"

report_delivery_channel {
Expand All @@ -35,7 +35,7 @@ resource "aws_backup_report_plan" "backup_restore_testing_jobs" {
}

resource "aws_backup_report_plan" "resource_compliance" {
name = "${local.resource_name_prefix}_resource_compliance"
name = replace("${local.resource_name_prefix}_resource_compliance", "-", "_")
description = "Report for showing whether resources are compliant with the framework"

report_delivery_channel {
Expand All @@ -55,7 +55,7 @@ resource "aws_backup_report_plan" "resource_compliance" {

resource "aws_backup_report_plan" "copy_jobs" {
count = var.backup_copy_vault_arn != "" && var.backup_copy_vault_account_id != "" ? 1 : 0
name = "${local.resource_name_prefix}_copy_jobs"
name = replace("${local.resource_name_prefix}_copy_jobs", "-", "_")
description = "Report for showing whether copies ran successfully in the last 24 hours"

report_delivery_channel {
Expand Down
2 changes: 1 addition & 1 deletion modules/aws-backup-source/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ terraform {
}
}

required_version = ">= 1.9.5"
required_version = ">= 1.4.0"
}