added optional field and description

NIAEFEUP · May 22, 2024 · 9d26b6e · 9d26b6e
1 parent 2318899
commit 9d26b6e
Show file tree

Hide file tree

Showing 3 changed files with 60 additions and 9 deletions.
diff --git a/src/models/CV.js b/src/models/CV.js
@@ -7,6 +7,11 @@ const CVSchema = new Schema({
         type: Schema.Types.ObjectId,
         required: true
     },
+    description: {
+        type: String,
+        maxlength: CVconstants.description.max_length,
+        minlength: CVconstants.description.min_length,
+    },
     projects: [{
         type: {
             name: {
@@ -44,26 +49,34 @@ const CVSchema = new Schema({
         type: String,
         maxlength: CVconstants.achievements.max_length,
         minlength: CVconstants.achievements.min_length,
-        default: null // Make it optional, set default to null
     },
     events: {
         type: String,
         maxlength: CVconstants.events.max_length,
         minlength: CVconstants.events.min_length,
-        default: null // Make it optional, set default to null
     },
     cvFileUrl: {
         type: String,
         maxlength: CVconstants.cvFileUrl.max_length,
         minlength: CVconstants.cvFileUrl.min_length,
-        default: null // Make it optional, set default to null
     },
     personalWebsite: {
         type: String,
         maxlength: CVconstants.personalWebsite.max_length,
         minlength: CVconstants.personalWebsite.min_length,
-        default: null // Make it optional, set default to null
-    }
+    },
+    personalizedFields: [{
+        fieldName: {
+            type: String,
+            required: true,
+            maxlength: CVconstants.personalizedFields.fieldName.max_length,
+        },
+        value: {
+            type: String,
+            required: true,
+            maxlength: CVconstants.personalizedFields.value.max_length,
+        },
+    }],
 });
 
 function arrayLengthValidator(arr) {

diff --git a/src/models/constants/CV.js b/src/models/constants/CV.js
@@ -3,6 +3,10 @@ export default Object.freeze({
         min_length: 2,
         max_length: 50,
     },
+    description: {
+        min_length: 2,
+        max_length: 200,
+    },
     language: {
         min_length: 2,
         max_length: 50,
@@ -27,15 +31,15 @@ export default Object.freeze({
         min_length: 2,
         max_length: 200,
     },
-    personalizedFields: [{
+    personalizedFields: {
         fieldName: {
             type: String,
             required: true,
-            maxlength: 100, // Adjust the max length as needed
+            maxlength: 100,
         },
         value: {
             type: String,
-            maxlength: 255, // Adjust the max length as needed
+            maxlength: 300,
         },
-    }],
+    },
 });
diff --git a/test/cv_schema.js b/test/cv_schema.js
@@ -111,6 +111,40 @@ describe("# CV Schema tests", () => {
                 expect(err.errors.personalWebsite).toBeUndefined();
             }
         });
+        test("'personalizedFields' field", async () => {
+            const cv = new CV({});
+            try {
+                await cv.validate();
+            } catch (err) {
+                expect(err.errors.personalizedFields).toBeUndefined();
+            }
+        });
+        test("'personalizedFields' array item must have fieldName", async () => {
+            const cv = new CV({ personalizedFields: [{ value: "value" }] });
+            try {
+                await cv.validate();
+            } catch (err) {
+                expect(err.errors["personalizedFields.0.fieldName"]).toBeDefined();
+                expect(err.errors["personalizedFields.0.fieldName"].kind).toBe("required");
+            }
+        });
+        test("'personalizedFields' array item must have value", async () => {
+            const cv = new CV({ personalizedFields: [{ fieldName: "fieldName" }] });
+            try {
+                await cv.validate();
+            } catch (err) {
+                expect(err.errors["personalizedFields.0.value"]).toBeDefined();
+                expect(err.errors["personalizedFields.0.value"].kind).toBe("required");
+            }
+        });
+        test("'description' ", async () => {
+            const cv = new CV({});
+            try {
+                await cv.validate();
+            } catch (err) {
+                expect(err.errors.description).toBeUndefined();
+            }
+        });
     });