-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
299 custom reason for application rejection #341
base: develop
Are you sure you want to change the base?
Conversation
Your Render PR Server URL is https://nijobs-backend-pr-341.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cljo2o98mmjc73bijve0. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #341 +/- ##
===========================================
- Coverage 90.34% 90.33% -0.01%
===========================================
Files 54 54
Lines 1470 1469 -1
Branches 246 245 -1
===========================================
- Hits 1328 1327 -1
Misses 137 137
Partials 5 5 ☔ View full report in Codecov by Sentry. |
it's worth mentioning that we had to alter the tests to include the new rejection messages but the tests cover the new code |
@odracir04 please rebase and update the |
b384d98
to
8992eff
Compare
f038ecc
to
47b92c2
Compare
the reason in the rejection email is now allowed to be specified by admins in the post request.