Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to edit offer redirects you to home page #324

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Trying to edit offer redirects you to home page #324

merged 3 commits into from
Oct 4, 2023

Conversation

FranciscoCardoso913
Copy link
Contributor

@FranciscoCardoso913 FranciscoCardoso913 commented Sep 13, 2023 •
edited
Loading

Closes #323

@FranciscoCardoso913 FranciscoCardoso913 linked an issue Sep 13, 2023 that may be closed by this pull request
Fix trying to edit offer redirects you to home page #323
Closed
@FranciscoCardoso913 @dsantosferreira
trying-to-edit-offer-redirects-you-to-home-page
a5f7e3a 
Co-authored-by: Daniel Ferreira <dsantosferreira@users.noreply.github.com>
@FranciscoCardoso913 FranciscoCardoso913 force-pushed the 323-fix-trying-to-edit-offer-redirects-you-to-home-page branch from af6f46a to a5f7e3a Compare September 13, 2023 18:48
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.05% ⚠️

Comparison is base (0cab005) 89.19% compared to head (d1ae9fc) 89.15%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #324      +/-   ##
===========================================
- Coverage    89.19%   89.15%   -0.05%     
===========================================
  Files          177      177              
  Lines         3434     3438       +4     
  Branches       866      869       +3     
===========================================
+ Hits          3063     3065       +2     
- Misses         371      373       +2
Files Changed Coverage Δ
src/components/Offers/New/CreateOfferForm.js 22.22% <0.00%> (-1.78%) ⬇️
src/components/Offers/Edit/EditOfferForm.js 92.30% <100.00%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsantosferreira dsantosferreira marked this pull request as draft September 13, 2023 19:50
@FranciscoCardoso913 FranciscoCardoso913 marked this pull request as ready for review September 16, 2023 12:16
@FranciscoCardoso913
Fixed: create offer form required Apply URl to submit and could not a…
d1ae9fc 
…ccess edit offer form of offer without applyURL
@FranciscoCardoso913 FranciscoCardoso913 force-pushed the 323-fix-trying-to-edit-offer-redirects-you-to-home-page branch from dc0bb95 to d1ae9fc Compare September 16, 2023 21:26
@FranciscoCardoso913 FranciscoCardoso913 merged commit 33eb94b into develop Oct 4, 2023
5 of 6 checks passed
@FranciscoCardoso913 FranciscoCardoso913 deleted the 323-fix-trying-to-edit-offer-redirects-you-to-home-page branch October 4, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naapperas Naapperas Naapperas approved these changes

@DoStini DoStini Awaiting requested review from DoStini

@BrunoRosendo BrunoRosendo Awaiting requested review from BrunoRosendo

@dsantosferreira dsantosferreira Awaiting requested review from dsantosferreira

Assignees

@FranciscoCardoso913 FranciscoCardoso913

@dsantosferreira dsantosferreira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix trying to edit offer redirects you to home page
3 participants
@FranciscoCardoso913 @Naapperas @dsantosferreira