Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: key/cert switchup for rtr-tls target #133

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

ember-ana
Copy link
Contributor

when defining a target with type = "rtr-tls", the config keys certificate and key refer to the respective other

actual

assuming test-data/localhost.crt and test-data/localhost.key

[targets.rtr-tls]
type = "rtr-tls"
certificate = "localhost.crt"
key = "localhost.key"

will fail with: TLS key file 'localhost.crt' does not contain any usable keys.

meanwhile

[targets.rtr-tls]
type = "rtr-tls"
key = "localhost.crt"
certificate = "localhost.key"

will start successfully

expected

[targets.rtr-tls]
type = "rtr-tls"
certificate = "localhost.crt"
key = "localhost.key"

should start successfully

@ember-ana ember-ana marked this pull request as ready for review February 3, 2025 15:35
@partim
Copy link
Member

partim commented Feb 4, 2025

Thank you for the PR! Looks perfect! (And also: oops.)

@partim partim merged commit 1c557e0 into NLnetLabs:main Feb 4, 2025
9 checks passed
@ember-ana ember-ana deleted the fix-tls-server-config branch February 5, 2025 16:32
ember-ana added a commit to ember-ana/rtrtr that referenced this pull request Feb 5, 2025
This PR fixes the rtr-tls target having certificate and key options reversed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants