Skip to content

Commit

Permalink
Merge pull request #1719 from NNPDF/multiclosure_internal_loader_t0co…
Browse files Browse the repository at this point in the history
…vmat

multiclosure internal dataset loader should use t0_covmat_from_systematics
  • Loading branch information
comane committed Apr 20, 2023
2 parents 7b314d5 + a6b92ee commit b5ee4ba
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions validphys2/src/validphys/closuretest/multiclosure.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
@check_use_t0
@check_t0pdfset_matches_multiclosure_law
def internal_multiclosure_dataset_loader(
dataset, fits_pdf, multiclosure_underlyinglaw, fits, dataset_inputs_t0_covmat_from_systematics
dataset, fits_pdf, multiclosure_underlyinglaw, fits, t0_covmat_from_systematics
):
"""Internal function for loading multiple theory predictions for a given
dataset and a single covariance matrix using underlying law as t0 PDF,
Expand Down Expand Up @@ -88,10 +88,10 @@ def internal_multiclosure_dataset_loader(
multiclosure_underlyinglaw, dataset
)

sqrt_covmat = la.cholesky(dataset_inputs_t0_covmat_from_systematics, lower=True)
sqrt_covmat = la.cholesky(t0_covmat_from_systematics, lower=True)
# TODO: support covmat reg and theory covariance matrix
# possibly make this a named tuple
return (fits_dataset_predictions, fits_underlying_predictions, dataset_inputs_t0_covmat_from_systematics, sqrt_covmat)
return (fits_dataset_predictions, fits_underlying_predictions, t0_covmat_from_systematics, sqrt_covmat)


@check_fits_underlying_law_match
Expand Down

0 comments on commit b5ee4ba

Please sign in to comment.