Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add luminosity channels #1762

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Add luminosity channels #1762

merged 2 commits into from
Jun 22, 2023

Conversation

Zaharid
Copy link
Contributor

@Zaharid Zaharid commented Jun 21, 2023

This adds lumi channels corresponding to the main production channels for W and Z bosons.

This adds lumi channels corresponding to the main production channels
for W and Z bosons.
@Zaharid Zaharid requested a review from scarlehoff June 21, 2023 14:21
@Zaharid
Copy link
Contributor Author

Zaharid commented Jun 21, 2023

@scarlehoff
Copy link
Member

Wouldn't it be better to have a parser so that one can use any combination? We have all the information necessary to understand things like:

lumi_channel: (u ubar, d dbar)

available

PDF4LHC20 = LinearBasis.from_mapping({

@Zaharid
Copy link
Contributor Author

Zaharid commented Jun 21, 2023 via email

@Zaharid
Copy link
Contributor Author

Zaharid commented Jun 21, 2023

Baring the very flaky tests, I'd like to merge this as is.

Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the comments with the change Xlum -> Xlum1 to signal it is only first generation quarks because I have the feeling this is the kind of thing that will come back to bite it in the future "wait, why does the Z luminosity remain unchanged even if the charm has changed a lot"

But not a worthy hill to die on and I'm happy also with being able to say "I told you so" when it eventually happens so feel free to merge.

validphys2/examples/pdf_lumi_plots.yaml Outdated Show resolved Hide resolved
validphys2/src/validphys/gridvalues.py Outdated Show resolved Hide resolved
validphys2/src/validphys/gridvalues.py Outdated Show resolved Hide resolved
validphys2/src/validphys/gridvalues.py Outdated Show resolved Hide resolved
validphys2/src/validphys/gridvalues.py Show resolved Hide resolved
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
@Zaharid Zaharid merged commit d6392ba into master Jun 22, 2023
4 checks passed
@Zaharid Zaharid deleted the wzlumis branch June 22, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants