-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add luminosity channels #1762
Add luminosity channels #1762
Conversation
This adds lumi channels corresponding to the main production channels for W and Z bosons.
Wouldn't it be better to have a parser so that one can use any combination? We have all the information necessary to understand things like:
available nnpdf/validphys2/src/validphys/pdfbases.py Line 533 in 7eb0c4e
|
I’d be happy to review such a pr. But it’s not this one. On 21 Jun 2023, at 16:04, Juan M. Cruz-Martinez ***@***.***> wrote:
Wouldn't it be better to have a parser so that one can use any combination? We have all the information necessary to understand things like:
lumi_channel: (u ubar, d dbar)
available https://github.com/NNPDF/nnpdf/blob/7eb0c4eb67604a7d0b80f9a8ac075aab994904cc/validphys2/src/validphys/pdfbases.py#L533
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Baring the very flaky tests, I'd like to merge this as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the comments with the change Xlum
-> Xlum1
to signal it is only first generation quarks because I have the feeling this is the kind of thing that will come back to bite it in the future "wait, why does the Z luminosity remain unchanged even if the charm has changed a lot"
But not a worthy hill to die on and I'm happy also with being able to say "I told you so" when it eventually happens so feel free to merge.
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
This adds lumi channels corresponding to the main production channels for W and Z bosons.