Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pineappl dependency to 0.6.2 #1842

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

RoyStegeman
Copy link
Member

@RoyStegeman RoyStegeman commented Nov 14, 2023

There were some bugfixes in pineappl since 0.5.8. Not sure if they affect anything we do in this repo but we may as well update it.

@scarlehoff
Copy link
Member

If tests pass I'm happy with this.

However, just to make sure... this last version of pineappl is compatible with eko 0.14 ? (cc @alecandido @cschwan @felixhekhorn) It should not matter for the nnpdf code, but just so that we make sure that people have a conda environment in which the different tools can talk with each other.

@alecandido
Copy link
Member

However, just to make sure... this last version of pineappl is compatible with eko 0.14 ? (cc @alecandido @cschwan @felixhekhorn) It should not matter for the nnpdf code, but just so that we make sure that people have a conda environment in which the different tools can talk with each other.

The PineAPPL interface we use has to be actually compatible with Pineko, that is making use of it.
There is also a direct interface between PineAPPL and EKO, that allows one to use the CLI, but this is not used in the Pineline (and it might be slightly broken because of the fix of the introduction of matching_order in the theory card, but I guess that it would just be ignored).

@RoyStegeman
Copy link
Member Author

This PR doesn't change much other than that it pins a lower bound. In practice 0.6.2 is already being downloaded in most cases: https://github.com/NNPDF/nnpdf/actions/runs/6862782721/job/18661228431#step:6:969

Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect then.

@RoyStegeman RoyStegeman merged commit d1f9331 into master Nov 14, 2023
4 checks passed
@RoyStegeman RoyStegeman deleted the update_pineappl_version branch November 14, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants