Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mamba in docker construction #1850

Merged
merged 1 commit into from
Nov 16, 2023
Merged

use mamba in docker construction #1850

merged 1 commit into from
Nov 16, 2023

Conversation

RoyStegeman
Copy link
Member

@RoyStegeman RoyStegeman commented Nov 16, 2023

Use mamba to build the docker to avoid passing the 6hour limit on the github CI

Since I force pushed it's not longer visible, but using mamba reduce the time of the "Build docker image and export environment" step to 3 minutes: https://github.com/NNPDF/nnpdf/actions/runs/6889900597/job/18741833824

@RoyStegeman RoyStegeman changed the title use mamba in docker.yml use mamba in docker construction Nov 16, 2023
@RoyStegeman RoyStegeman added the devtools Build, automation and workflow label Nov 16, 2023
Copy link
Contributor

@andreab1997 andreab1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I am not an expert so probably better wait for @scarlehoff

@RoyStegeman RoyStegeman merged commit 0e6c147 into master Nov 16, 2023
5 checks passed
@RoyStegeman RoyStegeman deleted the test_docker branch November 16, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools Build, automation and workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants