Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make weight initialization reproducible #1923

Merged
merged 9 commits into from
Mar 8, 2024
Merged

Make weight initialization reproducible #1923

merged 9 commits into from
Mar 8, 2024

Commits on Mar 8, 2024

  1. Make weight initialization reproducible 

    Remove option for replica seeds to be None in Preprocessing

Uniformize naming of layers in NN

Add test comparing 3 ways of running

darwin->linux

Simplify quickcards

increase tolerance

Change axis in weight constraint

Add test on constraint

Simplify constraint, tighten test

Test weights only

Revert "Simplify constraint, tighten test"

This reverts commit df8781f.

Clarify error message

Avoid duplicate checks

Change test cases

Avoid seed=0 issue with Keras 3
    @APJansen
    APJansen committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    91eeeee View commit details
    Browse the repository at this point in the history

  2. Remove outdated comment

    @APJansen
    APJansen committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5f2f5d7 View commit details
    Browse the repository at this point in the history

  3. Remove Optional for replica_seeds 

    Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
    @APJansen @scarlehoff
    APJansen and scarlehoff committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    75a749e View commit details
    Browse the repository at this point in the history

  4. replica_seeds -> _replica_seeds

    @APJansen
    APJansen committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    862678c View commit details
    Browse the repository at this point in the history

  5. Remove separate numpy import

    @APJansen
    APJansen committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    166e5eb View commit details
    Browse the repository at this point in the history

  6. Automatically regenerated regressions from PR 1923, branch reproducib… 

    …ility.
    @APJansen
    Redo regressions bot authored and APJansen committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    24af718 View commit details
    Browse the repository at this point in the history

  7. Automatically regenerated regressions from PR 1923, branch reproducib… 

    …ility.
    @APJansen
    Redo regressions bot authored and APJansen committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8d7cb85 View commit details
    Browse the repository at this point in the history

  8. Update fitbot reference

    @APJansen
    APJansen committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    cad20ff View commit details
    Browse the repository at this point in the history

  9. Prevent phi2 from vanishing by using different seeds for replicas

    @APJansen
    APJansen committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5936290 View commit details
    Browse the repository at this point in the history