Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fk refactor #1936

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Fk refactor #1936

merged 8 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. Refactor FK contractions

    @APJansen @scarlehoff
    APJansen authored and scarlehoff committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f356241 View commit details
    Browse the repository at this point in the history

  2. Precompute masked fk tables

    @APJansen @scarlehoff
    APJansen authored and scarlehoff committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d667545 View commit details
    Browse the repository at this point in the history

  3. enforce einsum order in DY

    @APJansen @scarlehoff
    APJansen authored and scarlehoff committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    66ae33b View commit details
    Browse the repository at this point in the history

  4. Refactor 1 replica DY

    @APJansen @scarlehoff
    APJansen authored and scarlehoff committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    54ef560 View commit details
    Browse the repository at this point in the history

  5. Implement Juan's suggestions. 

    Add timing comment

additional comment

Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
    @APJansen @scarlehoff
    APJansen and scarlehoff committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6eccda2 View commit details
    Browse the repository at this point in the history

  6. Rewrite masked_fk as padded_fk

    @APJansen @scarlehoff
    APJansen authored and scarlehoff committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f5530d5 View commit details
    Browse the repository at this point in the history

  7. Automatically regenerated regressions from PR 1936, branch fk-refactor.

    Redo regressions bot committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3bb6389 View commit details
    Browse the repository at this point in the history

  8. fitbot updated due to refactor of convolution layers in PR #1936

    @scarlehoff
    scarlehoff committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    dc57bf8 View commit details
    Browse the repository at this point in the history