-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of hyperopt model selection #1976
Open
Cmurilochem
wants to merge
8
commits into
master
Choose a base branch
from
dev_hyperopt_model_selection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmurilochem
force-pushed
the
dev_hyperopt_model_selection
branch
from
March 8, 2024 08:36
fe55608
to
8679dca
Compare
Cmurilochem
force-pushed
the
dev_hyperopt_model_selection
branch
2 times, most recently
from
March 12, 2024 16:48
d7a3873
to
e5294e8
Compare
Cmurilochem
force-pushed
the
dev_hyperopt_model_selection
branch
from
March 18, 2024 08:16
e5294e8
to
14efc0c
Compare
Cmurilochem
force-pushed
the
dev_hyperopt_model_selection
branch
from
April 19, 2024 07:48
14efc0c
to
21c5a06
Compare
Cmurilochem
force-pushed
the
dev_hyperopt_model_selection
branch
from
May 27, 2024 06:43
21c5a06
to
695c722
Compare
Cmurilochem
force-pushed
the
dev_hyperopt_model_selection
branch
2 times, most recently
from
June 12, 2024 07:12
2ea055a
to
aa61cb7
Compare
…cas of the best fit
Radonirinaunimi
force-pushed
the
dev_hyperopt_model_selection
branch
from
October 2, 2024 18:37
b44c2ee
to
535ea80
Compare
Can we review plus merge this now @Radonirinaunimi or do we want to wait for ref. replies? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement #1962 into
validphys
vp-hyperoptplot.py
.Updates
The model selection following to the
min_chi2_max_phi
algorithm (refactored frombest_chi2_worst_phi2
in #1962) could be done in two ways:1. via a basic script that imports validphys
hyperopt_dataframe
An example is shown below:
where
best_setup
corresponds to the model which shows the lowest 1/phi among those with the lowest chi2, whilebest_models
is a pandasDataFrame
containing allmax_phi_n_models
.2. via vp-hyperoptplot
by running:
which would launch an html file in your browser with some statistics and plots (I thinks this could be shared within the NNPDF server later on)
TODO: add a table in the html file containing the detailed specs of
best_models
.