Add a test for all commondata files #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarlehoff
force-pushed
the
fix_cross_correlation_type
branch
from
ce33c1a
to
d1f1f2a
Compare
scarlehoff
force-pushed
the
add_test_for_commondata
branch
from
8349c67
to
821fdfc
Compare
RoyStegeman
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Seems fine to me!
I can't think of an important check that's missing. If you really wanted there are some more checks on the metadata you could add, but since the checks you can do will never cover all mistakes someone implementing a dataset can make it may become a bit random and pointless.
| @@ -159,7 +160,8 @@ def _hqp_yq_xq2map(kin_dict): | |||
|
|
|||
| def _hqp_yqq_xq2map(kin_dict): | |||
| # Compute x, Q2 | |||
| ratio = np.sqrt(kin_dict[_Vars.m_t2]) / kin_dict[_Vars.sqrts] | |||
| mass2 = _get_or_fail(kin_dict, [_Vars.m_t2, _Vars.m_ttBar]) | |||
There was a problem hiding this comment.
Why do you do _get_or_fail here but not for the variables?
There was a problem hiding this comment.
The others will fail if they are not there (because it's a dict). It's just a way of having some general control over the situation of having more than one possibility for one variable. Although right now is basically a dictionary.get with a fallback
Co-authored-by: Roy Stegeman <roystegeman@live.nl>
scarlehoff
force-pushed
the
add_test_for_commondata
branch
from
2ce705c
to
1fe20fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am skipping the error due to #1991 since I guess that will take some time (and better to have some testing as soon as possible).
I am checking:
HQP_MQQandINCare not implemented inprocess_options#1991)statkey is correctly usedMULTorADDAll of this is checked for all datasets and variant regardless of whether they have a theory or not.
Any other ideas for things to test?
This closes #1990
(the current failure is for a fix already in master, will rebase)