Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the NNPDF docs #1998

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Updates to the NNPDF docs #1998

merged 7 commits into from
Mar 12, 2024

Conversation

mariaubiali
Copy link
Contributor

Hi all,
I changed initial page, added new bib references and added instructions for installation from source on M3. This is just the beginning, any suggestions for extra things to modify are more than welcome.

@RoyStegeman
Copy link
Member

Thanks @mariaubiali. Since you're making changes to the people in the collaboration, could you please also update Zahari's position?

@mariaubiali
Copy link
Contributor Author

Thanks @RoyStegeman, well spotted, done! I have moved Zahari from current to past and added info on his current position

@Radonirinaunimi
Copy link
Member

Thanks @mariaubiali! Given that this installation now works for all M macs, could you also please remove the M1/M2 section?

@scarlehoff
Copy link
Member

scarlehoff commented Mar 11, 2024

Before merging this, let's test a bit the python 3.12 installation #1989
(I'd like to check that the change in reportengine won't have unintended consequences) then we can remove also the python 3.11 bit.

Also, since now we have a pineappl package also for Apple Silicon we can collapse the development installation for both mac and linux into just what's in this PR.

@mariaubiali
Copy link
Contributor Author

Thanks @Radonirinaunimi I have removed that paragraph and now have "Installation from source on M1-M2-M3 Mac". Could someone check if the section above "Installation from Source" is still up-to-date?

@RoyStegeman
Copy link
Member

Could someone check if the section above "Installation from Source" is still up-to-date?

Thanks for asking. That's still fine.

@RoyStegeman
Copy link
Member

RoyStegeman commented Mar 11, 2024

I updated the docs a little bit. I now mention the nolha option, but I'm not sure we should since if it's in the docs we may have to provide support for it.

Removed it.

Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I think it can be merged.

Maybe we want to say explicitly that it works in any mac and linux system?

(btw, it might even work in windows provided lhapdf is available :P)

doc/sphinx/source/get-started/installation.rst Outdated Show resolved Hide resolved
@Radonirinaunimi
Copy link
Member

Maybe we want to say explicitly that it works in any mac and linux system?

I would add such a sentence indeed!

(btw, it might even work in windows provided lhapdf is available :P)

It is a big IF condition xD

@RoyStegeman RoyStegeman merged commit 3e4ce38 into master Mar 12, 2024
7 checks passed
@RoyStegeman RoyStegeman deleted the Update_docs branch March 12, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants