Fix a bunch of dataset names #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The question is... how should we deal with fixes to the names... (since this is relatively new, I'd rather have runcards that used the wrong name fail) |
scarlehoff
added
redo-regressions
CMS_Z0_8TEV_PT-Y: CMS_Z0J_8TEV_PT-Y ATLAS_WMWP_13TEV_TOT: ATLAS_WPWM_13TEV_TOT CMS_WP_7TEV_ELECTRON_ASY: CMS_WPWM_7TEV_ELECTRON_ASY CMS_WP_7TEV_MUON_ASY: CMS_WPWM_7TEV_MUON_ASY fix CMS Z0J (Z0 -> Z0J) fix the name everywhere it appears abuse dataset_names for bugfixes fix naming convention in docs ATLAS_WMWP_13TEV_TOT -> ATLAS_WPWM_13TEV_TOT CMS_WP_7TEV -> CMS_WPWM_7TEV update also folder name remove hacky bugfix
scarlehoff
force-pushed
the
fix_cms_z_zj
branch
from
99af468
to
c50771f
Compare
Radonirinaunimi
approved these changes
Mar 14, 2024
|
Is there a baseline fit with these corrected that can be used for reports? |
I don't believe so, unless @scarlehoff already has one but not uploaded? |
|
No. But anything with the old names will work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process for a few datasets is wrong:
edit: regression tests will fail because the seed depends on the name