Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add y labels, integrate utils in filters and remove comma in sys names v2 #2021

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

t7phy
Copy link
Member

@t7phy t7phy commented Mar 25, 2024

It seems there was an oversight on my part when opening #2020 that I hadn't noticed that nnpdf_data was already available as a standalone package that can be used while importing. This ofc allows (without any temporary breaking of filter files) to import utils from 1 place, as was agreed in CM. ATLAS_TTBAR_13TEV_HADR_DIF contains these utils and all the other ttb/jets/dis+j call whichever functions they need from here. This reduces code repetition and makes the review simpler.
To summarize:

@t7phy t7phy requested a review from RoyStegeman March 27, 2024 22:59
Copy link
Member

@Radonirinaunimi Radonirinaunimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM now.

@t7phy t7phy merged commit 19930c1 into master Mar 28, 2024
6 checks passed
@t7phy t7phy deleted the multiple_fixes_v2 branch March 28, 2024 08:12
@RoyStegeman RoyStegeman mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants