Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polarised Jet commondata implementation #2035

Merged
merged 82 commits into from
Jul 16, 2024
Merged

Polarised Jet commondata implementation #2035

merged 82 commits into from
Jul 16, 2024

Conversation

toonhasenack
Copy link
Collaborator

@toonhasenack toonhasenack commented Apr 4, 2024

Here we provide the implementation of the polarized Jet dataset.

Datasets marked with ✅ have been implemented and checked while those with ❌ are removed and no longer are part of the implementation.

1.1 datasets

Datasets Obs. Correlation Status Comments Inspire HepData
PHENIX_1JET_200GEV_ALL $A_{LL}$ no Ready Table 18 paper dataset
STAR_2005_1JET_200GEV_ALL $A_{LL}$ no Ready Figure 14 paper dataset
STAR_2006_1JET_200GEV_ALL $A_{LL}$ no Ready Figure 15 paper dataset
STAR_2009_1JET_200GEV_ALL $A_{LL}$ Correlations Ready Table 3, 4 paper dataset

New datasets

Datasets Obs. Correlation Status Comments Inspire HepData
STAR_2004_1JET_200GEV_ALL $A_{LL}$ no Ready Figure 3 paper dataset
STAR_2005_1JET_200GEV_ALL $A_{LL}$ no Deprecated (?) Figure 3 paper dataset
STAR_2009_2JET_SS_200GEV_ALL STAR_2009_2JET_OS_200GEV_ALL $A_{LL}$ Correlations Ready Tables 7, 9 paper dataset
STAR_2009_2JET_A_200GEV_ALL STAR_2009_2JET_B_200GEV_ALL STAR_2009_2JET_C_200GEV_ALL $A_{LL}$ Correlations Ready Figure 9 (3 topologies) paper dataset
STAR_2012_1JET_510GEV_ALL $A_{LL}$ ✅ see paper appendix Ready Figure 12 paper dataset
STAR_2012_2JET_A_510GEV_ALL STAR_2012_2JET_B_510GEV_ALL STAR_2012_2JET_C_510GEV_ALL, STAR_2012_2JET_D_510GEV_ALL $A_{LL}$ ✅ see paper appendix Ready Figure 14 (4 topologies) paper dataset
STAR_2015_1JET_200GEV_ALL $A_{LL}$ ✅ Tabs 4-13 Ready Table 1 paper dataset
STAR_2015_2JET_MIDRAP_SS_200GEV_ALL STAR_2015_2JET_MIDRAP_OS_200GEV_ALL $A_{LL}$ ✅ Tabs 4-13 Ready Table 2 (top, bottom), with correlated with 1JET paper dataset
STAR_2013_1JET_510GEV_ALL $A_{LL}$ ✅ HepData Ready Figure 3 paper dataset
STAR_2013_2JET_A_510GEV_ALL STAR_2013_2JET_B_510GEV_ALL STAR_2013_2JET_C_510GEV_ALL STAR_2013_2JET_D_510GEV_ALL $A_{LL}$ ✅ HepData Ready Figure 5 paper dataset

@Radonirinaunimi Radonirinaunimi marked this pull request as draft April 9, 2024 08:46
@toonhasenack
Copy link
Collaborator Author

Please @giacomomagni, add
sys.path.append('../../')
to all the files in which you changed to symmetrize_error import. Otherwise the filter.py's don't work

@giacomomagni
Copy link
Contributor

giacomomagni commented Apr 23, 2024

Please @giacomomagni, add sys.path.append('../../') to all the files in which you changed to symmetrize_error import. Otherwise the filter.py's don't work

weird to me they work as they are right now...

EDIT: you should change the way you are importing as:

from nnpdf_data.filter_utils.correlations import compute_covmat

this way it would work without appending the path

Copy link
Member

@Radonirinaunimi Radonirinaunimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor fixes.

@enocera
Copy link
Contributor

enocera commented Jul 2, 2024

@giacomomagni I talked to Elke Aschenauer about the set of data that we consider and the treatment of uncertainties.
Elke is saying two things.

  1. There are two additional papers on single inclusive jets that we may want to consider. These are arXiv:0710.2048 and hep-ex/0608030. These are rather old and measurements have rather large uncertainties (this is the reason why they were not considered in NNPDFpol1.1). If it is not too much effort, we may consider to include them.
  2. Concerning correlations, she confirmed that the recipe to be used is the following (for all of the jet and dijet data). One takes the correlation matrix and multiplies each entry by a total uncertainty, which is the sum in quadrature of the statistical and systematic uncertainties (except special uncs, like the pol. beam uncertainty, which we already treat separately). So, in other words: the provided correlation matrix already takes into account the fact that statistical uncertainties in dijets are uncorrelated. Therefore, also for dijets one has to multiply the corr mat. entries by the sum in quadrature of stat. and sys. uncs.

@giacomomagni
Copy link
Contributor

giacomomagni commented Jul 2, 2024

Hi @enocera, thank you for your message.

  • Point 2. I'm happy to implement the prescription suggested by Elke Aschenauer. I'll do it asap and get back to you.
  • Point 1. I think we can include the data from hep-ex/0608030 which were taken in 2003-2004. Regarding the other reference arXiv:0710.2048, I was thinking if the dataset STAR_2005_1JET_200GEV_ALL arXiv:1205.2735 contains already that information in an updated version. Both papers say that data were recored in 2005 with a luminosity of 2.1 pb^-1. Could you plese confirm?

@giacomomagni giacomomagni merged commit e3f7086 into master Jul 16, 2024
5 of 6 checks passed
@giacomomagni giacomomagni deleted the Jet_commondata branch July 16, 2024 12:58
@scarlehoff
Copy link
Member

Please, avoid merging PRs when the tests are still not passing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data toolchain Polarised Polarised PDF fits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants