Regenerate test pol #2053
Merged
Regenerate test pol #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radonirinaunimi
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the polarized tests (by doing them a bit less aggressively and in double precision) and adds a test for the TSR sum rules.
I’ve also made the polarized sum rules depend on the nn seed (I think it is fair to consider them part of the nn).
Now, I don’t like the double precision part, it means that there’s some instability affecting the polarized fit. I’ll try to figure out where is it coming from but I think it can be detached from the rest of the polarized fit (as it is just a numerical issue).