Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (and use) a default for IterEv #2062

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

scarlehoff
Copy link
Member

@scarlehoff scarlehoff commented Apr 24, 2024

I wanted to deal with this comment by @felixhekhorn #2028 (comment) and it ended up growing so much that I thought it would be better to separate it in its own PR so it can be reviewed before merging it to #2028.

This does very little:

  1. Adds some conditional default (and tests for them)
  2. Ensures that evolven3fit will make use of that default and, in addition, will loudly fail if someone tries to mix stuff.

@scarlehoff scarlehoff added the run-fit-bot Starts fit bot from a PR. label Apr 24, 2024
Copy link

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

@scarlehoff scarlehoff removed the run-fit-bot Starts fit bot from a PR. label Apr 25, 2024
@scarlehoff
Copy link
Member Author

scarlehoff commented Apr 25, 2024

@niclaurenti @giacomomagni please, have a look at my solution to avoid the need for find_nf in evolven3fit.
For the photon we are taking Q0 as the value the photon needs to be evolved to and so it makes sense (I believe) to take nf0 as well as the target nf (while qedref is an input argument).

I don't think compute_eko_photon is tested anywhere though so please look closely.

I've put find_nf as a method although the theory card is mostly accessed as a dictionary at the moment but if (eventually) the Theory class is passed around this can be used to find nf directly.

@scarlehoff scarlehoff merged commit 8e4eb08 into single_truth Apr 30, 2024
6 checks passed
@scarlehoff scarlehoff deleted the add_default_for_itev branch April 30, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants