Allow for underscore in theoryfiles #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyStegeman
force-pushed
the
allow_for_underscore_in_theoryfiles
branch
2 times, most recently
from
ffde1c1
to
a9fd1da
Compare
scarlehoff
reviewed
Jun 2, 2024
RoyStegeman
force-pushed
the
allow_for_underscore_in_theoryfiles
branch
from
e283f4b
to
aa580f5
Compare
scarlehoff
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
LGTM, just one comment, since you added a get_available_theory_cards function could you use that function also in fetch_all (at the end of the theorydbutils.py file).
It doesn't change anything practically, but it makes sure that there's only one place where available theories are listed.
RoyStegeman
force-pushed
the
allow_for_underscore_in_theoryfiles
branch
from
e498143
to
77fc18a
Compare
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.