Execute new commondata generation in CI #2099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radonirinaunimi
force-pushed
the
check_newcd
branch
2 times, most recently
from
44f6938
to
47c71b5
Compare
add manual trigger add workflow revert mistakenly deleted file
add filter dependencies as exras & remove underscore
Radonirinaunimi
force-pushed
the
check_newcd
branch
from
dbb3cc9
to
306db71
Compare
|
There are a few datasets that have changed. Many of them are due to numerical fluctuations, so #2095 needs to be propagated. List of datasets that have been modified |
Radonirinaunimi
commented
Jul 31, 2024
There was a problem hiding this comment.
Looking at the datasets one-by-one, the changes in the uncertainties are due to:
- numerical fluctuations which are solved by Don't save more decimals than necessary in the uncertainty (or data) files #2095
- changes of signs due to the decomposition of the covmats (cc @enocera).
There are only a few datasets (CMS_1JET_8TEV and some of the STAR data [cc @giacomomagni]) for which there are changes not attributed to one of the above.
There was a problem hiding this comment.
This one contains non-numerical changes.
There was a problem hiding this comment.
not sure why this happens, I see some syst have a sign change, but identical value...
There was a problem hiding this comment.
The change of signs are completely fine (this can happen and for these we can just take the absolute values), but the change of values might be a bit more concerning. In this particular example, for the first bin, before sys_34: -1.1083988795952688e-05 while now sys_34: -2.7915793127758835e-06 (while everything above is fine).
There was a problem hiding this comment.
If I run the filter locally I do get the old numbers.
But maybe it's because I'm using a different version of numpy.
env
(nnpdf) giacomomagni@Giacomos-MacBook-Pro STAR_2013_1JET_510GEV % pip list
WARNING: Ignoring invalid distribution -andas (/Users/giacomomagni/.conda/envs/nnpdf/lib/python3.10/site-packages)
Package Version Editable project location
----------------------------- ----------------------------------- -------------------------------------------------
absl-py 2.1.0
aiohttp 3.9.5
aiosignal 1.2.0
alabaster 0.7.12
appdirs 1.4.4
astroid 2.15.8
asttokens 2.4.1
astunparse 1.6.3
asv 0.4.2
async-timeout 4.0.3
attrs 23.1.0
Babel 2.11.0
backcall 0.2.0
banana-hep 0.6.11
black 23.7.0
blessings 1.7
blinker 1.6.2
Bottleneck 1.3.8
brotlipy 0.7.0
build 0.10.0
CacheControl 0.13.1
cachetools 5.3.3
certifi 2024.7.4
cffi 1.15.1
cfgv 3.4.0
charset-normalizer 2.0.4
cleo 2.0.1
click 8.1.7
cloudpickle 3.0.0
colorama 0.4.6
commonmark 0.9.1
contourpy 1.2.0
coverage 7.5.3
crashtest 0.4.1
cryptography 41.0.2
curio 1.4
cycler 0.12.1
dask 2024.6.0
decorator 5.1.1
devtools 0.10.0
dill 0.3.7
distlib 0.3.7
distributed 2024.6.0
dm-tree 0.1.8
docutils 0.16
dulwich 0.21.6
eko 0.14.3
exceptiongroup 1.2.1
executing 2.0.1
fancycompleter 0.9.1
fiatlux 0.1.3
filelock 3.12.4
flatbuffers 2.0
fonttools 4.44.0
frozenlist 1.4.0
fsspec 2024.6.0
future 1.0.0
gast 0.4.0
google-auth 2.29.0
google-auth-oauthlib 0.4.4
google-pasta 0.2.0
greenlet 3.0.1
grpcio 1.51.1
h5py 3.11.0
hyperopt 0.2.7
hypothesis 6.99.5
identify 2.5.36
idna 3.4
imagesize 1.4.1
importlib-metadata 6.0.0
iniconfig 2.0.0
installer 0.7.0
ipdb 0.13.13
ipython 8.18.1
isort 5.12.0
jaraco.classes 3.3.0
jedi 0.19.1
Jinja2 3.1.2
jsonschema 4.17.3
keras 2.11.0
Keras-Preprocessing 1.1.2
keyring 24.2.0
kiwisolver 1.4.5
latexcodec 2.0.1
lazy-object-proxy 1.10.0
LeProHQ 0.2.5
LHAPDF 6.5.0
libclang 18.1.1
llvmlite 0.42.0
locket 1.0.0
lz4 4.3.2
Markdown 3.4.1
MarkupSafe 2.1.1
matplotlib 3.7.5
matplotlib-inline 0.1.7
mccabe 0.7.0
mkl-fft 1.3.6
mkl-random 1.2.2
mkl-service 2.4.0
ml-dtypes 0.3.2
more-itertools 10.1.0
msgpack 1.0.8
multidict 6.0.4
munkres 1.1.4
mypy-extensions 1.0.0
namex 0.0.8
networkx 3.3
nnpdf 4.0.9.post1159.dev0+803fab771.dirty
nodeenv 1.9.1
numba 0.59.1
numexpr 2.8.4
numpy 1.26.4
oauthlib 3.2.2
opt-einsum 3.3.0
optree 0.11.0
packaging 23.1
pandas 2.1.4
parso 0.8.4
partd 1.4.2
pastel 0.2.1
pathspec 0.11.2
pdbpp 0.10.3
pendulum 2.1.2
pexpect 4.9.0
pickleshare 0.7.5
Pillow 10.1.0
pineappl 0.8.2
pineko 0.0.0 /Volumes/Git_Workspace/physicstools/pineko
pip 24.2
pkginfo 1.10.0
platformdirs 3.11.0
pluggy 1.4.0
poethepoet 0.10.0
poetry 1.6.1
poetry-core 1.7.0
poetry-plugin-export 1.5.0
pre-commit 3.7.1
prompt_toolkit 3.0.47
protobuf 3.20.3
psutil 6.0.0
ptyprocess 0.7.0
pure-eval 0.2.2
py4j 0.10.9.7
pyasn1 0.4.8
pyasn1-modules 0.2.8
pybtex 0.24.0
pybtex-docutils 1.0.3
pycparser 2.21
Pygments 2.18.0
PyJWT 2.8.0
pylint 2.17.7
pymongo 3.12.0
pyOpenSSL 23.2.0
pyparsing 3.1.1
pyproject_hooks 1.0.0
pyrepl 0.9.0
pyrsistent 0.19.3
PySocks 1.7.1
pytest 8.1.1
pytest-cov 5.0.0
pytest-env 1.1.3
pytest-mpl 0.17.0
python-dateutil 2.9.0.post0
pytz 2024.1
PyYAML 6.0.1
rapidfuzz 2.15.2
recommonmark 0.6.0
reportengine 0.30.dev0
requests 2.31.0
requests-oauthlib 2.0.0
requests-toolbelt 1.0.0
rich 12.6.0
rsa 4.7.2
ruamel.yaml 0.17.21
ruamel.yaml.clib 0.2.6
ruamel-yaml-conda 0.15.100
scipy 1.13.0
seaborn 0.13.2
setuptools 68.2.2
shellingham 1.5.3
six 1.16.0
snowballstemmer 2.2.0
sortedcontainers 2.4.0
Sphinx 5.0.2
sphinx-rtd-theme 1.1.1
sphinxcontrib-applehelp 1.0.2
sphinxcontrib-bibtex 2.6.1
sphinxcontrib-devhelp 1.0.2
sphinxcontrib-htmlhelp 2.0.0
sphinxcontrib-jsmath 1.0.1
sphinxcontrib-qthelp 1.0.3
sphinxcontrib-serializinghtml 1.1.5
SQLAlchemy 1.4.50
stack-data 0.6.3
tblib 3.0.0
tensorboard 2.11.0
tensorboard-data-server 0.6.1
tensorboard-plugin-wit 1.6.0
tensorflow 2.11.0
tensorflow-estimator 2.11.0
tensorflow-io-gcs-filesystem 0.37.0
termcolor 2.1.0
tomli 2.0.1
tomlkit 0.12.1
toolz 0.12.1
tornado 6.4.1
tqdm 4.66.4
traitlets 5.14.3
trove-classifiers 2023.10.18
typing_extensions 4.11.0
tzdata 2024.1
urllib3 1.26.16
validobj 1.2
virtualenv 20.24.5
wcwidth 0.2.13
Werkzeug 3.0.3
wheel 0.43.0
wmctrl 0.5
wrapt 1.14.1
xattr 0.10.1
yadism 0.0.0 /Volumes/Git_Workspace/physicstools/NN3PDF/yadism
yarl 1.9.3
zict 3.0.0
zipp 3.11.0
There was a problem hiding this comment.
Ok, I will have a close look.
There was a problem hiding this comment.
This too, to check.
There was a problem hiding this comment.
This one also seems to contain non-numerical changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1457.
Remaining to do:
nnpdf_data/nnpdf_data/new_commondata