Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend n3fit and vp to deal with two different initial state distributions #2110

Merged
merged 58 commits into from
Jul 30, 2024

Conversation

Radonirinaunimi
Copy link
Member

@Radonirinaunimi Radonirinaunimi commented Jun 7, 2024

The following PR modifies both n3fit and vp to deal with the case in which (SI)DIS/DY processes involve convolutions between two different distributions (PDF, pPDF, FF, etc.). A simple example of such a scenario is the case in which one of the protons is polarized and the other not:

$$\Delta \mathcal{R} = \frac{\sum \Delta f \otimes f \otimes \Delta \Sigma}{\sum f \otimes f \otimes \Sigma}$$

This PR introduces a feature available since pineappl <v0.8.0 that specifies the type of convolution required by an initial state with the convolution_type_ key (whose value can be UnpolPDF, PolPDF, FF).

The main modifications affect:

  • the new convolution that includes the $\Delta V$ and $\Delta V_3$ distributions
  • the convolution during the fits in which one of the distributions is computed from a boundary condition
  • the computation of the theory predictions in vp
    • $\chi^2$-computations
    • data vs theory comparisons
  • allow for computations of theory uncertainties (computing of the theory covariance matrix)

Minimal non-congruent modifications:

  • deprecate the is_polarized logical
  • modify the polarized Positivity commondata to impose the BCs on the individual pPDF flavors

To do at the very last stage:

  • re-generate the regression tests
  • update the documentations

Rely on NNPDF/pineappl#289, NNPDF/pineko#181.

@Radonirinaunimi Radonirinaunimi added enhancement New feature or request Polarised Polarised PDF fits labels Jun 7, 2024
@Radonirinaunimi Radonirinaunimi marked this pull request as draft June 7, 2024 09:06
@Radonirinaunimi Radonirinaunimi self-assigned this Jun 17, 2024
@scarlehoff scarlehoff added redo-regressions Recompute the regression data run-fit-bot Starts fit bot from a PR. labels Jul 26, 2024
@scarlehoff scarlehoff added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. redo-regressions Recompute the regression data labels Jul 26, 2024
Copy link

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the reports / fits to be ready to make sure, but lgtm

@Radonirinaunimi
Copy link
Member Author

Radonirinaunimi commented Jul 28, 2024

Everything now works as expected here (and consistent with previous results). For the record, here are some extensive fit comparisons: https://vp.nnpdf.science/tEj54eRbTkeWaSXqA3MQWQ==/

@scarlehoff scarlehoff removed the run-fit-bot Starts fit bot from a PR. label Jul 29, 2024
Radonirinaunimi and others added 2 commits July 29, 2024 13:20
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, I'm going to try and run a parallel fit with this branch.

Looking through the changes in n3fit I noticed a potential bug running polarized fits in parallel. I'll report back once the fits are finished.
For the rest (docs, -sequential- fits, reports) everything looks ok.

n3fit/src/n3fit/layers/DY.py Outdated Show resolved Hide resolved
n3fit/src/n3fit/layers/DY.py Outdated Show resolved Hide resolved
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
@Radonirinaunimi Radonirinaunimi merged commit aab2313 into master Jul 30, 2024
6 checks passed
@Radonirinaunimi Radonirinaunimi deleted the polarised-dy branch July 30, 2024 09:02
@scarlehoff
Copy link
Member

Here's a report comparing one of the fits in @Radonirinaunimi's report, with the fit run in a GPU.

https://vp.nnpdf.science/KV97c7yfTRCt5PEOZ6Dh1g==

Everything seems to work well :)

(given past experiences I want to make sure we have a lot of granularity around these commits that can potentially change things in the fit behavior!)

@Radonirinaunimi
Copy link
Member Author

Here's a report comparing one of the fits in @Radonirinaunimi's report, with the fit run in a GPU.

https://vp.nnpdf.science/KV97c7yfTRCt5PEOZ6Dh1g==

Everything seems to work well :)

(given past experiences I want to make sure we have a lot of granularity around these commits that can potentially change things in the fit behavior!)

Perfect! Thanks a lot for this check @scarlehoff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics Polarised Polarised PDF fits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants