-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sihp data #2154
Sihp data #2154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, rebase on top of master after I merge #2153
nnpdf_data/nnpdf_data/new_commondata/STAR-2006_SHP_200GEV/metadata.yaml
Outdated
Show resolved
Hide resolved
nnpdf_data/nnpdf_data/new_commondata/STAR-2006_SHP_200GEV/metadata.yaml
Outdated
Show resolved
Hide resolved
nnpdf_data/nnpdf_data/new_commondata/STAR-2006_SHP_200GEV/metadata.yaml
Outdated
Show resolved
Hide resolved
@Radonirinaunimi given that the naming convention is <exp.name>_<misc.info>, I think it would better to have years in the <misc.info> section instead of renaming the experiments to include the year. |
It depends whether the different years should be taken as separated experiments (when using per-experiment grouping for instance). So with (btw, for a moment I thought "Why do we have an 'all' observable, what does that mean?" 😆 ) |
Introduced here: #2142. |
nnpdf_data/nnpdf_data/new_commondata/PHENIX-2009_SHP_200GEV/uncertainties.yaml
Outdated
Show resolved
Hide resolved
nnpdf_data/nnpdf_data/new_commondata/STAR-2006_SHP_200GEV/uncertainties.yaml
Outdated
Show resolved
Hide resolved
I think these measurements might be also relevant (cc @enocera): STAR 510 GeV: https://inspirehep.net/literature/1674826 Charged hadrons (just for reference): |
5af0d56
to
e3f1e3a
Compare
I've implemented them. The reference for PHENIX was not the correct one (it contains the charged measurements) and I rectified it in the table above. These measurements, AFAIU, were performed in ~2012-2013 but I just took 2013 for all of them.
Given that we'll not include this in the paper, I will not implement them now but rather do so once we have interfaced https://github.com/NNPDF/sihp-pp. |
@scarlehoff please check that 7301318 address all the required changes in terms of having new process options. And with this, modulo reviews, this PR is done AFAIC. |
Thanks @Radonirinaunimi, sorry for linking the wrong reference... to many papers indeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Radonirinaunimi
do you want to wait until the grids are ready to merge it? (so that it is merged "completed" with the right grid names even if the fktables are not in the theory yet)
nnpdf_data/nnpdf_data/commondata/STAR-2006_SHP_200GEV/kinematics.yaml
Outdated
Show resolved
Hide resolved
I think it'd be best to merge this as implementing the PineAPPL interface to produce the grids might take some time, mainly because we'll have to fix the C and Fortran APIs once |
@Radonirinaunimi before merging, could you please add the identified hadron name somewhere in the dataset name or observable name (wherever you prefer). Having the PI0 mentioned explcitly in the names and not having to look in the metadata description would be super helpful especially when moving towards FF fits and preparing runcards. |
Good point! Especially since for some experiments/measurements we have different final state hadrons. To conform with the other dataset namings (such as gauge boson production) I added the type and charge to the dataset name. |
Thanks! |
This adds the single hadron production datasets:
These do not have the corresponding FK tables yet but we do have the codes to generate the predictions NNPDF/sihp-pp.