-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implementation of CMS single top #2200
base: master
Are you sure you want to change the base?
Conversation
Following up on @scarlehoff suggestion in PR#2185 to compare the overall experimental chi2 with all datasets combined, I'm attaching here the reports: Regarding the ordering, for each dataset, legacy always appears first and is followed by the new commondata implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please, bump the version number and change the version comment just like in the ATLAS one.
Although, I think you forgot to add some of the filter.py
files?
(btw, like in the ATLAS pr, rebase on top of master please)
- uncertainties_legacy_TCHANNEL-XSEC.yaml | ||
data_central: data_legacy_TCHANNEL-XSEC.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- uncertainties_legacy_TCHANNEL-XSEC.yaml | |
data_central: data_legacy_TCHANNEL-XSEC.yaml | |
- uncertainties_TCHANNEL-XSEC.yaml |
Since the data and uncertainties are unchanged, please remove the old files and just make legacy
point to the new one.
(we may remove legacy
eventually when they are exactly equal, but one thing at a time)
@@ -0,0 +1,33 @@ | |||
meta: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove this runcard from here (maybe put in the PR for reference)
(it will be eventually removed alongside all the rawdata anyway)
This PR reimplements CMS single top. All datasets agree with the legacy implementation.
All metadata has been updated accordingly.