Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implementation of CMS single top #2200

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jacoterh
Copy link
Collaborator

@jacoterh jacoterh commented Nov 7, 2024

This PR reimplements CMS single top. All datasets agree with the legacy implementation.

  • CMS_SINGLETOP_7TEV: no hepdata entry available. I manually checked legacy against the experimental paper and found perfect agreement.
  • CMS_SINGLETOP_8TEV: hepdata entry is available. Filter implemented and found perfect agreement. Validphys report this PR vs legacy.
obs = "TCHANNEL-XSEC"

new_implementation = f"CMS_SINGLETOP_8TEV_{obs}"
old_implementation = f"CMS_SINGLETOP_8TEV_{obs}"

inp1 = {
    "dataset_input": {"dataset": f"{new_implementation}"},
    "theoryid": 40_000_000,
    "use_cuts": "internal",
    "t0pdfset": "NNPDF40_nnlo_as_01180",
    "use_t0": True,
}
inp2 = {
    "dataset_input": {"dataset": f"{old_implementation}", "variant": "legacy"},
    "theoryid": 40_000_000,
    "use_cuts": "internal",
    "t0pdfset": "NNPDF40_nnlo_as_01180",
    "use_t0": True,
}

covmat1 = API.covmat_from_systematics(**inp1)
covmat2 = API.covmat_from_systematics(**inp2)

t0_covmat1 = API.t0_covmat_from_systematics(**inp1)
t0_covmat2 = API.t0_covmat_from_systematics(**inp2)

print(f"Comparison for {new_implementation}")
print(np.all(np.isclose(covmat1, covmat2)))
print(np.all(np.isclose(t0_covmat1, t0_covmat2)))

>>> Comparison for CMS_SINGLETOP_8TEV_TCHANNEL-XSEC
>>> True
>>> True
  • CMS_SINGLETOP_13TEV: no hepdata entry available. I manually checked legacy against the experimental paper and found perfect agreement.

All metadata has been updated accordingly.

@jacoterh jacoterh marked this pull request as ready for review November 8, 2024 12:00
@jacoterh
Copy link
Collaborator Author

Following up on @scarlehoff suggestion in PR#2185 to compare the overall experimental chi2 with all datasets combined, I'm attaching here the reports:

Regarding the ordering, for each dataset, legacy always appears first and is followed by the new commondata implementation.

Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please, bump the version number and change the version comment just like in the ATLAS one.

Although, I think you forgot to add some of the filter.py files?

(btw, like in the ATLAS pr, rebase on top of master please)

Comment on lines +58 to +59
- uncertainties_legacy_TCHANNEL-XSEC.yaml
data_central: data_legacy_TCHANNEL-XSEC.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uncertainties_legacy_TCHANNEL-XSEC.yaml
data_central: data_legacy_TCHANNEL-XSEC.yaml
- uncertainties_TCHANNEL-XSEC.yaml

Since the data and uncertainties are unchanged, please remove the old files and just make legacy point to the new one.

(we may remove legacy eventually when they are exactly equal, but one thing at a time)

@@ -0,0 +1,33 @@
meta:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this runcard from here (maybe put in the PR for reference)

(it will be eventually removed alongside all the rawdata anyway)

@scarlehoff scarlehoff added the Done PRs that are done but waiting on something else to merge/approve label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data toolchain Done PRs that are done but waiting on something else to merge/approve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants