Skip to content

Commit

Permalink
update scallop example
Browse files Browse the repository at this point in the history
  • Loading branch information
andybeet committed Apr 17, 2024
1 parent 1cf5d69 commit 297b8e4
Show file tree
Hide file tree
Showing 21 changed files with 411 additions and 160 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ inst/doc

# folders
other
!docs

# files
*.png
Expand Down
12 changes: 5 additions & 7 deletions docs/404.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 5 additions & 7 deletions docs/LICENSE-text.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 25 additions & 27 deletions docs/articles/ExploreFishingData.html

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,12 @@ See https://github.com/DataTables/DataTablesSrc/issues/160
table.dataTable {
display: table;
}


/*
When DTOutput(fill = TRUE), it receives a .html-fill-item class (via htmltools::bindFillRole()), which effectively amounts to `flex: 1 1 auto`. That's mostly fine, but the case where `fillContainer=TRUE`+`height:auto`+`flex-basis:auto` and the container (e.g., a bslib::card()) doesn't have a defined height is a bit problematic since the table wants to fit the parent but the parent wants to fit the table, which results pretty small table height (maybe because there is a minimum height somewhere?). It seems better in this case to impose a 400px height default for the table, which we can do by setting `flex-basis` to 400px (the table is still allowed to grow/shrink when the container has an opinionated height).
*/

.html-fill-container > .html-fill-item.datatables {
flex-basis: 400px;
}
12 changes: 5 additions & 7 deletions docs/articles/atlantiscas.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

130 changes: 107 additions & 23 deletions docs/articles/dataQAQC.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,12 @@ See https://github.com/DataTables/DataTablesSrc/issues/160
table.dataTable {
display: table;
}


/*
When DTOutput(fill = TRUE), it receives a .html-fill-item class (via htmltools::bindFillRole()), which effectively amounts to `flex: 1 1 auto`. That's mostly fine, but the case where `fillContainer=TRUE`+`height:auto`+`flex-basis:auto` and the container (e.g., a bslib::card()) doesn't have a defined height is a bit problematic since the table wants to fit the parent but the parent wants to fit the table, which results pretty small table height (maybe because there is a minimum height somewhere?). It seems better in this case to impose a 400px height default for the table, which we can do by setting `flex-basis` to 400px (the table is still allowed to grow/shrink when the container has an opinionated height).
*/

.html-fill-container > .html-fill-item.datatables {
flex-basis: 400px;
}
14 changes: 7 additions & 7 deletions docs/articles/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 297b8e4

Please sign in to comment.