Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update/clean package documentation #75

Merged
merged 11 commits into from
Sep 25, 2024
Merged

update/clean package documentation #75

merged 11 commits into from
Sep 25, 2024

Conversation

andybeet
Copy link
Member

@andybeet andybeet commented Sep 24, 2024 •
edited
Loading

New content

  • Overview.rmd - place holder to describle methods, assumptions,caveats etc. Added caveat regarding SPPVALUE not used prior to 1981
  • Added argument definitions for get_comland_data function
  • Added get_herring_data help file
  • Added NEWS.md
  • Added package logo

Documentation clean

  • inheritParams used to pull argument definitions from main get_comland_data to other functions downstream
  • added links to external urls (NAFO) and internal vignettes (Overview)
  • removed text relating to files being saved on users machine
  • made some functions internal (not exported)

Moved Content

  • removed old functions

@andybeet andybeet linked an issue Sep 24, 2024 that may be closed by this pull request
SPPVALUE not available before 1982? #74
Closed
@andybeet andybeet requested a review from sgaichas September 24, 2024 19:41
@andybeet
Copy link
Member Author

@sgaichas . need to fix a couple of addition things. Can you hang on merging this?

@sgaichas
Copy link
Member

no rush!

@andybeet
Copy link
Member Author

@sgaichas good to go

sgaichas
sgaichas approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@sgaichas sgaichas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and looks good. I like the icon :-) Thanks!

@sgaichas sgaichas merged commit 7890eec into dev Sep 25, 2024
2 checks passed
@andybeet andybeet linked an issue Oct 7, 2024 that may be closed by this pull request
what is comland_menhaden #12
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgaichas sgaichas sgaichas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

what is comland_menhaden SPPVALUE not available before 1982?
2 participants
@andybeet @sgaichas