Skip to content

Completes LETKF task, adds WCDA CI test #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Nov 7, 2024
Merged

Completes LETKF task, adds WCDA CI test #1287

merged 35 commits into from
Nov 7, 2024

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

Completes LETKF task, adds WCDA CI test

Mutually dependent on NOAA-EMC/global-workflow#2944

@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request Sep 19, 2024
Merged
16 tasks
guillaumevernieres
guillaumevernieres reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request Sep 20, 2024
Closed
4 tasks
CoryMartin-NOAA
CoryMartin-NOAA reviewed Sep 30, 2024
View reviewed changes
WalterKolczynski-NOAA added a commit to NOAA-EMC/global-workflow that referenced this pull request Oct 30, 2024
@AndrewEichmann-NOAA @WalterKolczynski-NOAA @DavidHuber-NOAA
Add run and finalize methods to marine LETKF task (#2944)
0b3304e 
Adds run and finalize methods to marine LETKF task, experiment yaml for
gw-ci in GDASApp, workflow additions, removes bugs found on the way, and
completes the bulk of the work on LETKF task. Conversion of fields to
increments pending.

Partially resolves NOAA-EMC/GDASApp#1091 and NOAA-EMC/GDASApp#1251

Mutual dependency with GDASApp PR
NOAA-EMC/GDASApp#1287 and IC fix file issue
#2944 (comment)

---------

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
@AndrewEichmann-NOAA
Copy link
Collaborator Author

The global-workflow PR has been merged: NOAA-EMC/global-workflow#2944

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Oct 31, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Oct 31, 2024
@emcbot
Copy link

emcbot commented Oct 31, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Oct 31 19:58:15 UTC 2024 on hfe08
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Oct 31 20:07:02 UTC 2024
Tests: 
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1287/global-workflow/sorc/gdas.cd/build/log.ctest

Build: SUCCESS
Build: Completed at Thu Oct 31 20:54:37 UTC 2024

Tests: Failed
Tests: Failed at Thu Oct 31 23:35:47 UTC 2024
Tests: 70% tests passed, 21 tests failed out of 69
1969 - test_gdasapp_WCDA-hyb-C48mx500_gdas_marinebmat_202103241800 (Failed)
1970 - test_gdasapp_WCDA-hyb-C48mx500_gdas_marineanlinit_202103241800 (Failed)
1971 - test_gdasapp_WCDA-hyb-C48mx500_gdas_marineanlvar_202103241800 (Failed)
1972 - test_gdasapp_WCDA-hyb-C48mx500_gdas_marineanlchkpt_202103241800 (Failed)
1973 - test_gdasapp_WCDA-hyb-C48mx500_gdas_marineanlfinal_202103241800 (Failed)
1977 - test_gdasapp_atm_jjob_var_init (Failed)
1978 - test_gdasapp_atm_jjob_var_run (Failed)
1979 - test_gdasapp_atm_jjob_var_inc (Failed)
1980 - test_gdasapp_atm_jjob_var_final (Failed)
1985 - test_gdasapp_atm_jjob_ens_sol (Failed)
1986 - test_gdasapp_atm_jjob_ens_inc (Failed)
1987 - test_gdasapp_atm_jjob_ens_final (Failed)
1989 - test_gdasapp_bufr2ioda_insitu_profile_argo (Failed)
1990 - test_gdasapp_bufr2ioda_insitu_profile_bathy (Failed)
1991 - test_gdasapp_bufr2ioda_insitu_profile_glider (Failed)
1992 - test_gdasapp_bufr2ioda_insitu_profile_tesac (Failed)
1993 - test_gdasapp_bufr2ioda_insitu_profile_tropical (Failed)
1994 - test_gdasapp_bufr2ioda_insitu_profile_xbtctd (Failed)
1995 - test_gdasapp_bufr2ioda_insitu_surface_drifter (Failed)
1996 - test_gdasapp_bufr2ioda_insitu_surface_trkob (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1287/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Oct 31, 2024
@AndrewEichmann-NOAA
Copy link
Collaborator Author

Are any of those failures unexpected?

@RussTreadon-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA , the only failures I expect are test_gdasapp_bufr2ioda_insitu failures

1989 - test_gdasapp_bufr2ioda_insitu_profile_argo (Failed)
1990 - test_gdasapp_bufr2ioda_insitu_profile_bathy (Failed)
1991 - test_gdasapp_bufr2ioda_insitu_profile_glider (Failed)
1992 - test_gdasapp_bufr2ioda_insitu_profile_tesac (Failed)
1993 - test_gdasapp_bufr2ioda_insitu_profile_tropical (Failed)
1994 - test_gdasapp_bufr2ioda_insitu_profile_xbtctd (Failed)
1995 - test_gdasapp_bufr2ioda_insitu_surface_drifter (Failed)
1996 - test_gdasapp_bufr2ioda_insitu_surface_trkob (Failed)

I think @apchoiCMD is investigating these failures,

@guillaumevernieres
Copy link
Contributor

Are any of those failures unexpected?

@givelberg is working on fixing the obs ctest, check the log for the rest. I suspect the jobs timed out.

@guillaumevernieres
Copy link
Contributor

Are any of those failures unexpected?

@AndrewEichmann-NOAA , can you fix the conflict and turn off the hybrid test? It won't work until a few things are merged in the g-w.

@AndrewEichmann-NOAA
Copy link
Collaborator Author

Are any of those failures unexpected?

@AndrewEichmann-NOAA , can you fix the conflict and turn off the hybrid test? It won't work until a few things are merged in the g-w.

@guillaumevernieres Done

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Nov 6, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Nov 6, 2024
@emcbot
Copy link

emcbot commented Nov 7, 2024

Automated GW GDASApp Testing Results:
Machine: hera

Start: Wed Nov  6 21:39:35 UTC 2024 on hfe05
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Nov  6 22:26:11 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Nov  7 00:35:02 UTC 2024
Tests: 80% tests passed, 13 tests failed out of 64
	1955 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marinebmat_202103241800 (Failed)
	1956 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlinit_202103241800 (Failed)
	1957 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlvar_202103241800 (Failed)
	1958 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlchkpt_202103241800 (Failed)
	1959 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlfinal_202103241800 (Failed)
	1968 - test_gdasapp_WCDA-hyb-C48mx500_gdas_marineanlletkf_202103241800 (Failed)
	1972 - test_gdasapp_atm_jjob_var_init (Failed)
	1973 - test_gdasapp_atm_jjob_var_run (Failed)
	1974 - test_gdasapp_atm_jjob_var_inc (Failed)
	1975 - test_gdasapp_atm_jjob_var_final (Failed)
	1980 - test_gdasapp_atm_jjob_ens_sol (Failed)
	1982 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1287/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Nov 7, 2024
@guillaumevernieres guillaumevernieres merged commit dfc871f into develop Nov 7, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/ens-WCDA-ctest branch November 7, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@apchoiCMD apchoiCMD Awaiting requested review from apchoiCMD

@givelberg givelberg Awaiting requested review from givelberg

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndrewEichmann-NOAA @emcbot @RussTreadon-NOAA @guillaumevernieres @CoryMartin-NOAA