-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add components to use jcb yamls for marine letkf job #1486
Open
AndrewEichmann-NOAA
wants to merge
8
commits into
develop
Choose a base branch
from
feature/letkf-j2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@AndrewEichmann-NOAA , make sure you're up to date with develop, assign yourself and trigger the ci on hpc. |
@guillaumevernieres Does checking the box queue the ci? |
Automated GW-GDASApp Testing Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds components to have the marine letkf job use jcb yamls, also reorders ctests to reflect marine letkf's new dependecy on the bmat task
Companion PRs
Companion to NOAA-EMC/jcb-algorithms#11 and future global-workflow PR
This shouldn't break anything as it is redundant - non-jcb yamls can be removed after the global-workflow PR gets merged
Issues
Partially addresses #1485
Automated CI tests to run in Global Workflow