-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several consistency fixes for all the conventional yamls #280
base: develop
Are you sure you want to change the base?
Conversation
Just for reference, here is a link to download a zip file with all the plots confirming no issues and showing improvements for each type. Note there is no aircft*35 obs, so there is not plot for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, results seem either positive or neutral. Just curious, does adding the obsgrouping
section do anything for surface obs or is that mainly for consistency with other obs types?
Well, mainly for consistency right now. The obsgrouping at the top is actually required for the ObsErrorFactorConventional (OEFC) function, but the OEFC is commented out for most of the yamls right now. OEFC will run without the obsgrouping, but I believe it will do nothing, so it is good to have it in there now. I think there is still a bug in the OEFC that I need to better understand and fix before I can turn it back on for the remainder to the obtypes. |
Ahh gotcha, I did not know that was required for OEFC. Thanks! |
@guoqing-noaa are there any questions about this on GSL's side? |
Description
This PR fixes several consistency issues between all current conventional validated yamls. The files will now be more easily comparable when opening side by side (e.g. using
vi -d adpsfc_airTemperature_187.yaml msonet_airTemperature_188.yaml
). New yamls are often modeled from previously built yamls, so this keeps new development clean and consistent. This PR also adds some filters that were previously missing from the earliest developed yamls in addition to slight reorganization of some filters. These changes do affect final results. The current baseline was run for every single case and a test was rerun for each updated yaml showing improvements across the board.Summary of changes:
Issue(s) addressed
No issue
Dependencies (if applicable)
None
Checklist