Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObsError group to radiance IODA obs via the offline domain check #287

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

SamuelDegelia-NOAA
Copy link
Contributor

@SamuelDegelia-NOAA SamuelDegelia-NOAA commented Feb 20, 2025

Bug Fix Description

This PR addresses #274. To prevent the empty DerivedObsError group from being created and used during LETKF, we need to include ObsError in the input IODA data for radiance obs. The bufr2ioda converters for radiance data are still in active development and are not ready to be committed to RDASApp. Thus, the easiest solution for us is to add ObsError via the offline domain check.

Here I updated offline_domain_check_satrad.py to create a ObsError group. The errors are initialized at 999 but will be filled in by the assign error filter action once JEDI is run. New radiance obs are created using this code and staged in RDAS_DATA. Those new obs are linked into RDASApp under this PR which resolves the issue of zero increments when running LETKF for these ob types.

The addition of the ObsError group to the IODA data only affects the LETKF solver. The ctest references for the Ens3Dvar are the exact same as before.

Issue(s) addressed

Resolves Issue #274

Dependencies (if applicable)

None

Checklist

  • I have performed a self-review of my own code.
  • I have run rrfs tests before creating the PR (if applicable).

@SamuelDegelia-NOAA
Copy link
Contributor Author

Hera ctests:

[Samuel.Degelia@hfe06 rrfs-test]$ ctest -j8
Test project /scratch2/BMC/zrtrr/Samuel.Degelia/RDASApp_fixrad/RDASApp/build/rrfs-test
    Start 2: rrfs_fv3jedi_2024052700_getkf_observer
    Start 4: rrfs_mpasjedi_2024052700_Ens3Dvar
    Start 7: rrfs_mpasjedi_2024052700_bumploc
    Start 1: rrfs_fv3jedi_2024052700_Ens3Dvar
    Start 5: rrfs_mpasjedi_2024052700_getkf_observer
    Start 8: rrfs_bufr2ioda_msonet
1/8 Test #8: rrfs_bufr2ioda_msonet .....................   Passed   32.36 sec
2/8 Test #2: rrfs_fv3jedi_2024052700_getkf_observer ....   Passed  104.94 sec
    Start 3: rrfs_fv3jedi_2024052700_getkf_solver
3/8 Test #5: rrfs_mpasjedi_2024052700_getkf_observer ...   Passed  118.40 sec
    Start 6: rrfs_mpasjedi_2024052700_getkf_solver
4/8 Test #1: rrfs_fv3jedi_2024052700_Ens3Dvar ..........   Passed  263.52 sec
5/8 Test #7: rrfs_mpasjedi_2024052700_bumploc ..........   Passed  308.25 sec
6/8 Test #3: rrfs_fv3jedi_2024052700_getkf_solver ......   Passed  207.17 sec
7/8 Test #4: rrfs_mpasjedi_2024052700_Ens3Dvar .........   Passed  338.13 sec
8/8 Test #6: rrfs_mpasjedi_2024052700_getkf_solver .....   Passed  235.65 sec

100% tests passed, 0 tests failed out of 8

Label Time Summary:
mpi            = 1608.43 sec*proc (8 tests)
rdas-bundle    = 1608.43 sec*proc (8 tests)
script         = 1608.43 sec*proc (8 tests)

Total Test time (real) = 354.09 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant