Add ObsError
group to radiance IODA obs via the offline domain check
#287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix Description
This PR addresses #274. To prevent the empty
DerivedObsError
group from being created and used during LETKF, we need to includeObsError
in the input IODA data for radiance obs. The bufr2ioda converters for radiance data are still in active development and are not ready to be committed to RDASApp. Thus, the easiest solution for us is to addObsError
via the offline domain check.Here I updated
offline_domain_check_satrad.py
to create aObsError
group. The errors are initialized at 999 but will be filled in by theassign error
filter action once JEDI is run. New radiance obs are created using this code and staged inRDAS_DATA
. Those new obs are linked into RDASApp under this PR which resolves the issue of zero increments when running LETKF for these ob types.The addition of the
ObsError
group to the IODA data only affects the LETKF solver. The ctest references for the Ens3Dvar are the exact same as before.Issue(s) addressed
Resolves Issue #274
Dependencies (if applicable)
None
Checklist