ESMF logging and tracing updates around RouteHandle setup #901
Conversation
|
@DusanJovic-NOAA I see that PRs need 2 approving reviews. I was going to add @junwang-noaa as a second reviewer, but for some reason I cannot even add reviewers. I have no idea why that is, since I am the author of the PR. Anyway, is there a way you can move this PR forward? Thanks. |
@theurich I think the fastest way to get this changes merged is to combine them with some other PR. If you agree, I can pull this in my branch for #929. |
@DusanJovic-NOAA yes, please, go ahead and combine #901 with your #929. Can you just edit my PR here, and change the target to your DusanJovic-NOAA:cubed_sphere_redist branch? |
|
@DusanJovic-NOAA after looking into this myself, I don't think it is possible to move the target branch of an existing PR to a target a different fork. If you are okay, I will just open a new PR into your fork/branch for #929, close #901, and go from there. |
Yes, please open a PR to DusanJovic-NOAA:cubed_sphere_redist |
|
Close this PR. Superseded by DusanJovic-NOAA#8. |
Description
The changes in this PR were made during the debugging effort when testing recent ESMF beta tags. This PR wants to preserve the diagnostic improvements.
The code changes are purely focused at providing improved diagnostic. They do not change the actual implementation of the procedure of setting up the RouteHandles. A few changes to what gets written to ESMF log files during the setup of RouteHandles between FCST and WRT components. Also add a few more ESMF trace regions for more complete coverage in the ESMF profile.