Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen restriction on optional arguments in CCPP. #917

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

dustinswales
Copy link
Contributor

Description

When optional arguments were added back into the CCPP as part of #189, all variables that were conditionally allocated on the host side were required to be defined as optional within the schemes. This restriction required host-model logic to be implicitly built into the schemes and metadata. For example, scheme variables that were optional in the context of the host model, but always required within the context scheme, still needed to be defined as optional within the scheme. This resulted in schemes having an arbitrary/confusing mis-match of required/optional arguments.

This PR contains changes to the CCPP Framework (PR627) and CCPP Physics (PR248), reducing the restrictions on optional arguments and corresponding schemes changes, respectively. (There is also a small bugfix for the LW Jacobian used by RRTMGP).

Issue(s) addressed

N/A

Testing

RTs pass on Hera using Intel
(Running the full set now and will updated with links to RT logs when they complete)

Dependencies

N/A

Requirements before merging

  • All new code in this PR is tested by at least one unit test
  • All new code in this PR includes Doxygen documentation
  • All new code in this PR does not add new compilation warnings (check CI output)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant