Adding New Vegetative Canopy Data for AQM Coupling #928
Conversation
… feature/aqm_canopy
|
@grantfirl Just touching base here as the UWM canopy PR is poised for approval. |
Can we get this PR moved forward for approval soon? @grantfirl @bbakernoaa @BrianCurtis-NOAA |
|
@bbakernoaa review? Thank you. |
|
@drnimbusrain please resolve the conflicts and I'll take a look |
|
@bbakernoaa OK, conflicts have been resolved here. Thank you for the review. |
|
Thank you @bbakernoaa for approving this! Looking forward to this moving forward with the UWM canopy package. |
|
You have the incorrect ccpp/physics hash, it should be the one from noaa-oar-arl/feature/aqm_canopy2 noaa-oar-arl/ccpp-physics@a57f1a0 |
@BrianCurtis-NOAA Thank you for that. I have updated the ccpp/physics hash to reflect my latest sync up for my branch. |
|
@drnimbusrain ufs-community/ccpp-physics#253 has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@5d6bacf) and revert the .gitmodules file in preparation for the merge. |
|
Brian, could you help here with this to get it merged?
Thank you!
…On Thu, Jul 17, 2025, 8:32 AM Rhae Sung Kim ***@***.***> wrote:
*rhaesung* left a comment (NOAA-EMC/fv3atm#928)
<#928 (comment)>
@drnimbusrain <https://github.com/drnimbusrain>
ufs-community/ccpp-physics#253
<ufs-community/ccpp-physics#253> has been merged.
Please update the submodule pointer for ccpp-physics (
***@***.***
<ufs-community/ccpp-physics@5d6bacf>)
and revert the .gitmodules file in preparation for the merge.
—
Reply to this email directly, view it on GitHub
<#928 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNSTSXBT7CQDJA5NQMT3I6JUZAVCNFSM6AAAAABWWMO5JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOBTHA4TEMJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@drnimbusrain sure, but i'll need collaborator permissions |
@BrianCurtis-NOAA Sure thing, just added you. Thank you! |
|
@rhaesung @DusanJovic-NOAA ready for merge. |
|
Thank you all so much!! |
Description
In this PR we add five new vegetative canopy datasets based on satellite observations, which is currently passed from the AQM chemical component to the ufs-weather-model for incorporation in the optional sub-canopy parameterizations in ccpp-physics PBL schemes (SATMEDMF). These include the forest canopy height (FCH), forest fraction (FRT), clumping index (CLU), population density (POPU), and leaf area index from (LAI). These datasets have recently been published in a NOAA-ARL Tech Memo and at NCEI. This also adds three additional AQM coupled photolysis diagnostics used in helping best evaluate and understand associated canopy effects in AQM.
Issue(s) addressed
#927
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
RDHPCs Hera.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes. These add new variables only used in ccpp-physics with option turned on. The do_canopy option is turned off by default. 'logical :: do_canopy = .false. !< flag for canopy option'
Have the ufs-weather-model regression test been run? On what platform?
No.
No. - Please commit the regression test log files in your ufs-weather-model branch
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
https://github.com/noaa-oar-arl/ccpp-physics/tree/feature/aqm_canopy2
Do PRs in upstream repositories need to be merged first?
@iri01