Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add echgres as a dependency for earc #3202

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add echgres as a dependency for earc #3202

wants to merge 3 commits into from

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jan 3, 2025 •
edited
Loading

Description

This PR:

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES/NO
  • Does this change require a documentation update? YES/NO
  • Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@aerorahul
Copy link
Contributor Author

@CatherineThomas-NOAA Can you please incorporate this change in the C1152 test that discovered this bug. The current CI testing will likely not run into this issue.

@aerorahul aerorahul mentioned this pull request Jan 3, 2025
Open
@CatherineThomas-NOAA
Copy link
Contributor

@aerorahul: I'll pull this change into gfs_tasks.py, regenerate the xml, and continue the experiment.

@CatherineThomas-NOAA
Copy link
Contributor

The XML was generated successfully. The difference:

914c914,917
<                       <metataskdep metatask="enkfgdas_epmn"/>
---
>                       <and>
>                               <metataskdep metatask="enkfgdas_epmn"/>
>                               <taskdep task="enkfgdas_echgres"/>
>                       </and>

I'll let the experiment get through one earc step before approving.

@aerorahul
Copy link
Contributor Author

The XML was generated successfully. The difference:

914c914,917
<                       <metataskdep metatask="enkfgdas_epmn"/>
---
>                       <and>
>                               <metataskdep metatask="enkfgdas_epmn"/>
>                               <taskdep task="enkfgdas_echgres"/>
>                       </and>

I'll let the experiment get through one earc step before approving.

looks correct to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA DavidHuber-NOAA is a code owner

@CatherineThomas-NOAA CatherineThomas-NOAA Awaiting requested review from CatherineThomas-NOAA

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aerorahul @CatherineThomas-NOAA @WalterKolczynski-NOAA