Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration updates and fixes for reforecast #3046

Conversation

EricSinsky-NOAA
Copy link
Contributor

@EricSinsky-NOAA EricSinsky-NOAA commented Oct 30, 2024

Description

This PR adds more configuration updates and fixes for the reforecast:

  • Fix seed for CA
  • Ensure HPSSARCH is set to YES by default
  • Fix a bug that prevented rectilinear gridded ocean products from archiving to HPSS
  • Use GEFS-DEV project and devmax queue by default (except for tasks that require external connectivity, which will use dev_transfer)
  • Remove ice_prod task
  • Download analysis data from next cycle instead of current cycle (needed for repair task)
  • Change HOMEDIR to gefstemp dir on WCOSS2

This PR will be left in draft mode until more testing is complete and more configuration settings are finalized.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Testing GEFS replay case on WCOSS2.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@EricSinsky-NOAA EricSinsky-NOAA marked this pull request as ready for review November 4, 2024 13:37
@EricSinsky-NOAA EricSinsky-NOAA merged commit b6208ee into NOAA-EMC:feature/gefs_reforecast Nov 4, 2024
5 checks passed
@EricSinsky-NOAA EricSinsky-NOAA deleted the feature/rfcst_updates branch November 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants