CI GitHub pipeline (hotfix) update for fetching repo name #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actch action code for feature PR repo names
.github/workflows/pw_aws_ci.yaml
Outdated
Comment on lines
75
to
77
| repo={{ github.repository }} | ||
| if [ "$pr_number" -eq "0" ]; then | ||
| branch=${{ github.event.inputs.ref }} | ||
| repo=${{ github.repository }} |
There was a problem hiding this comment.
I'm a little confused by the syntax used here with {{}} and $. Is this Jinja or is this specific syntax for GitHub workflows?
To retain consistency, I'm guessing that this should be
Suggested change
| repo={{ github.repository }} | |
| if [ "$pr_number" -eq "0" ]; then | |
| branch=${{ github.event.inputs.ref }} | |
| repo=${{ github.repository }} | |
| repo=${{ github.repository }} | |
| if [ "$pr_number" -eq "0" ]; then | |
| branch=${{ github.event.inputs.ref }} |
There was a problem hiding this comment.
Yes ${{ gitsutff }} is specific GitHub syntax, and yes line 75 was a typo
.github/workflows/pw_aws_ci.yaml
Outdated
Comment on lines
75
to
77
| repo={{ github.repository }} | ||
| if [ "$pr_number" -eq "0" ]; then | ||
| branch=${{ github.event.inputs.ref }} | ||
| repo=${{ github.repository }} |
There was a problem hiding this comment.
Yes ${{ gitsutff }} is specific GitHub syntax, and yes line 75 was a typo
WalterKolczynski-NOAA
pushed a commit
to WalterKolczynski-NOAA/global-workflow
that referenced
this pull request
Nov 22, 2024
) # Description<!-- This description will become the commit message for the PR. --> Simple bug fix to GitHub CI pipeline script for Parallel Works. Introduced a bug on its last update for setting the repo name in advance of running the GitHub CLI command for getting the repo owner and branch name of PRs. # Type of change - [x] Bug fix (fixes something broken) - [ ] New feature (adds functionality) - [ ] Maintenance (code refactor, clean-up, new CI test, etc.) # Change characteristics <!-- Choose YES or NO from each of the following and delete the other --> - Is this a breaking change (a change in existing functionality)? NO - Does this change require a documentation update? NO - Does this change require an update to any of the following submodules? # How has this been tested? Gets tested when update to default repo gets checked in. --------- Co-authored-by: Terry McGuinness <Terry.McGuinness@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple bug fix to GitHub CI pipeline script for Parallel Works.
Introduced a bug on its last update for setting the repo name in advance of running the GitHub CLI command for getting the repo owner and branch name of PRs.
Type of change
Change characteristics
How has this been tested?
Gets tested when update to default repo gets checked in.