Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JGDAS_ENKF_SFC and JGDAS_ENKF_UPDATE jobs with COMIN/COMOUT instead of COM #3170

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
+152,990 −51

Merge branch 'develop' into feature/jgdas_enkf_sfc_update_com_in_out

5cde120
Select commit
Loading
Failed to load commit list.
Open

Update JGDAS_ENKF_SFC and JGDAS_ENKF_UPDATE jobs with COMIN/COMOUT instead of COM #3170

Merge branch 'develop' into feature/jgdas_enkf_sfc_update_com_in_out
5cde120
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / ShellCheck failed Jan 23, 2025 in 5s

1,042 new alerts including 20 errors

New alerts in code changed by this pull request

  • 20 errors
  • 156 warnings
  • 866 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 39 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 43 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check warning on line 48 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

This expression is constant. Did you forget the $ on a variable? Warning test

This expression is constant. Did you forget the $ on a variable?

Check notice on line 56 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. Note test

Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.

Check notice on line 57 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 65 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 69 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 71 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 74 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 77 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 88 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 91 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 91 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 94 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 97 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 101 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 102 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 103 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check warning on line 109 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

testvar appears unused. Verify use (or export if used externally). Warning test

testvar appears unused. Verify use (or export if used externally).

Check warning on line 110 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

var1 appears unused. Verify use (or export if used externally). Warning test

var1 appears unused. Verify use (or export if used externally).

Check warning on line 111 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

var2 appears unused. Verify use (or export if used externally). Warning test

var2 appears unused. Verify use (or export if used externally).

Check warning on line 112 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

var4 appears unused. Verify use (or export if used externally). Warning test

var4 appears unused. Verify use (or export if used externally).

Check notice on line 113 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore). Note test

Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore).

Check notice on line 125 in sorc/ufs_model.fd/tests/atparse.bash

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice on line 4 in sorc/ufs_model.fd/tests/auto-jenkins/start_rt_auto_jenkins.sh

See this annotation in the file changed.

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.