Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional fixes for downstream jobs #3187

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from
Draft

Additional fixes for downstream jobs #3187

wants to merge 16 commits into from

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Dec 20, 2024 •
edited
Loading

Description

This fixes a number of issues with the postsnd and arch jobs discovered during testing of HR4.

Resolves #3019

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Extended test on Hera
  • Extended test on WCOSS2

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
    • Portions of this change are covered by existing CI, but others are not (e.g. archiving, which is disabled on WCOSS2)
    • Updates will need to be made to run the AWIPS jobs in the existing C96_atm3DVar_extended test

@DavidHuber-NOAA
Only archive gempak if it was run
5974b96
@DavidHuber-NOAA
Remove literal quotes
2649a86
@DavidHuber-NOAA
Shellcheck stuff
a038cb9
@DavidHuber-NOAA
Remove duplicate marinebmat entry
1180627
@DavidHuber-NOAA
Add DO_GEMPAK to archive environment
1efe711
@DavidHuber-NOAA
Merge remote-tracking branch 'emc/develop' into fix/awips
4b7d39e 
* emc/develop:
  Change orog gravity wave drag scheme for grid sizes less than 10km (NOAA-EMC#3175)
  Switch snow DA to use 2DVar for deterministic and ensemble mean (NOAA-EMC#3163)
  Update compression options for GEFS history files (NOAA-EMC#3184)
@DavidHuber-NOAA
Copy link
Contributor Author

All post jobs now run for the C96_atm3dvar_extended test when DO_AWIPS=YES on WCOSS2. I have thus enabled AWIPS for this test to ensure the AWIPS jobs and linked downstream jobs are always run to avoid lapses in support.

The AWIPS jobs still cannot be enabled on other machines due to the fbwinds executable which currently only runs on WCOSS2. That will be an issue for another time.

Also, during this testing, I found that the MOS jobs, when enabled, do not run on WCOSS2. I opened issue #3196 to look into this, but I believe the MOS package will need an overhaul to work with the new COM structure.

Marking this PR ready for review.

@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review December 30, 2024 19:01
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Dec 30, 2024
Merged
22 tasks
aerorahul
aerorahul reviewed Dec 31, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one observation. Approve.

workflow/applications/gfs_cycled.py Show resolved Hide resolved
aerorahul
aerorahul approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@aerorahul
Copy link
Contributor

@WalterKolczynski-NOAA
Can you please run the ci on wcoss2?

@DavidHuber-NOAA DavidHuber-NOAA added CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Jan 6, 2025
@DavidHuber-NOAA
Copy link
Contributor Author

Running CI in /lfs/h2/emc/global/noscrub/David.Huber/RT/3187.

@DavidHuber-NOAA
Copy link
Contributor Author

All CI tests completed successfully. However, I ran a C48_S2SW test case with DO_AWIPS, DO_GEMPAK, DO_GOES, DO_BUFRSND, and DO_NPOESS all set to YES, and discovered a number of failures in gempak and awips jobs. Converting back to draft while I resolve these issues.

@DavidHuber-NOAA DavidHuber-NOAA removed the CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress label Jan 6, 2025
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as draft January 6, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

@GwenChen-NOAA GwenChen-NOAA Awaiting requested review from GwenChen-NOAA GwenChen-NOAA is a code owner

@BoCui-NOAA BoCui-NOAA Awaiting requested review from BoCui-NOAA BoCui-NOAA is a code owner

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post processing errors resulting from GFS HR4 test run
3 participants
@DavidHuber-NOAA @aerorahul @WalterKolczynski-NOAA