Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various wave updates: Reformat WW3 inputs; enable PIO for wave restarts; enable WW3 cycling; synchronize UFS restart writes; add uglo_15km WW3 grid #3190

Open
wants to merge 118 commits into
base: develop
Choose a base branch
from

Conversation

JessicaMeixner-NOAA
Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Dec 20, 2024

Description

This PR adds the following:

Notes on ufs-weather-model updates:

Commit date Commit hash/ PR Notes for g-w changes Baseline Changes
Dec 11, 2024 ufs-community/ufs-weather-model@409bc85 ufs-community/ufs-weather-model#2419 Enables flexible restart writes - changes included in g-w PR none
Dec 16, 2024 ufs-community/ufs-weather-model@6ec6b45 ufs-community/ufs-weather-model#2528 ufs-community/ufs-weather-model#2469 n/a HAFs test changes, no global changes
Dec 18, 2024 ufs-community/ufs-weather-model@e119370 ufs-community/ufs-weather-model#2448 Adds Gaea C6 support (changes in other g-w PRs, not here) none
Dec 23, 2024 ufs-community/ufs-weather-model@2950089 ufs-community/ufs-weather-model#2533 ufs-community/ufs-weather-model#2538 changes for ESMF vs traditional threading none
Dec 30, 2024 ufs-community/ufs-weather-model@241dd8e ufs-community/ufs-weather-model#2485 n/a changes in conus13km, no global changes
Jan 3, 2025 ufs-community/ufs-weather-model@76471dc ufs-community/ufs-weather-model#2530 n/a changes in regional tests, no global changes

Note this PR requires the following:

  • update to fix files to add uglo_15km
  • staging ICs for high resolution test case for uglo_15km

Co-author: @sbanihash

Related Issues:

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)

Change characteristics

How has this been tested?

Tests were done by adding waves to C48mx500 3DVar tests for cycling.
High resolution tests cases were also added.

This likely needs a new round of testing before CI and after staged ICs & new fix files are added.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

JessicaMeixner-NOAA and others added 30 commits July 15, 2024 16:55
JessicaMeixner-NOAA and others added 7 commits January 6, 2025 13:22
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. A few suggestions to make the distinction between binary and netcdf restarts explicit.

ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_postdet.sh Show resolved Hide resolved
ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_postdet.sh Show resolved Hide resolved
JessicaMeixner-NOAA and others added 9 commits January 6, 2025 18:40
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
aerorahul
aerorahul previously approved these changes Jan 7, 2025
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
We can set the labels to test if you are ready for it.

@JessicaMeixner-NOAA
Copy link
Contributor Author

looks good to me. We can set the labels to test if you are ready for it.

fix files are still needed and I'm working to stage high-res ICs. Running a last test or two before I'm ready to pass off the fix files. Also - as soon as #3188 is merged, there will be conflicts to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants