Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily comment out LMOD_TMOD_FIND_FIRST=yes in module-setup.sh. Move it to ush/load_ufsda_modules.sh for runtime usage. Left note to undo these changes when WCOSS2 is using spack-stack. Refs NOAA-EMC#3225
KateFriedman-NOAA
requested review from
DavidHuber-NOAA,
WalterKolczynski-NOAA,
aerorahul and
CoryMartin-NOAA
as code owners
RussTreadon-NOAA
approved these changes
Jan 15, 2025
DavidHuber-NOAA
approved these changes
Jan 15, 2025
|
Wondering if the LD_LIBRARY_PATH business can also be done in load_ufsda_modules.sh in an wcoss if-block to isolate non-spack built executables from it. |
This is a good idea. Need to test to confirm that it works as intended. |
|
Thanks all! In the interest of getting this fix in, I will now merge this. Please consider making the additional |
KateFriedman-NOAA
added a commit
to KateFriedman-NOAA/global-workflow
that referenced
this pull request
Jan 15, 2025
…kf_sfc_update_com_in_out * upstream/develop: Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229) Reinstate product groups (NOAA-EMC#3208) Additional fixes for downstream jobs (NOAA-EMC#3187) Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215) Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220) Update upload-artifact to v4 (NOAA-EMC#3216) Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217) Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
KateFriedman-NOAA
added a commit
to KateFriedman-NOAA/global-workflow
that referenced
this pull request
Jan 15, 2025
…kf_sfc_update_com_in_out * upstream/develop: Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229) Reinstate product groups (NOAA-EMC#3208) Additional fixes for downstream jobs (NOAA-EMC#3187) Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215) Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220) Update upload-artifact to v4 (NOAA-EMC#3216) Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217) Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
KateFriedman-NOAA
added a commit
to KateFriedman-NOAA/global-workflow
that referenced
this pull request
Jan 15, 2025
…kf_sfc_update_com_in_out * upstream/develop: Resolve bug with LMOD_TMOD_FIND_FIRST setting affecting build on WCOSS2 (NOAA-EMC#3229) Reinstate product groups (NOAA-EMC#3208) Additional fixes for downstream jobs (NOAA-EMC#3187) Turn IAU off during staging job for cold start experiments (NOAA-EMC#3215) Update the gdas.cd hash and enable GDASApp to run on WCOSS2 (NOAA-EMC#3220) Update upload-artifact to v4 (NOAA-EMC#3216) Prevent duplicate case generation in generate_workflows.sh (NOAA-EMC#3217) Update g-w to cycle with C1152 ATM (NOAA-EMC#3206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR temporarily comments out the
LMOD_TMOD_FIND_FIRST=yessetting inush/module-setup.sh. Have moved it toush/load_ufsda_modules.shfor runtime usage for now. Left note to undo these changes when WCOSS2 is using spack-stack.Also found and corrected a spelling mistake.
Resolves #3225
Type of change
Change characteristics
Build and runtime script updates.
How has this been tested?
Ran CI tests on WCOSS2-Cactus.