Skip to content

Refine the method defining destination path for aerosol obs #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

RussTreadon-NOAA
Copy link
Contributor

Description

This PR modifies a single line in ush/python/pygfs/task/aero_prepobs.py so that modification of the destination path for aerosol observation is limited to the basename part of the path.

This change is required to successfully run gcdas_prepobsaero from GDASApp ctest test_gdasapp_C96_gcafs_cycled

Resolves #3794

Type of change

  • Bug fix (fixes something broken when running GDASApp ctests)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Clone and build on Hera as part of GDASApp stable-nightly testing.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jun 12, 2025
@RussTreadon-NOAA RussTreadon-NOAA added the JEDI Feature development to support JEDI-based DA label Jun 13, 2025
@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review June 16, 2025 16:16
@RussTreadon-NOAA
Copy link
Contributor Author

This PR is required in order to successfully run GDASApp GCAFS ctests.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @CoryMartin-NOAA for the quick review and approval.

test_gdasapp_C96_gcafs_cycled_gcdas_prepobsaero_202112201800 failed in GDASApp PR #1750 hera-GW-RT with

OSError: Unable to copy /scratch1/NCEPDEV/global/glopara/dump/gdas.20211220/18/atmos/gdas.t18z.viirs_npp_aod.tm00.nc to /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1750/global-workflow/sorc/gcdas.cd/build/gcdas/test/gw-ci/../../test/gw-ci/C96_gcafs_cycled/COMROOT/C96_gcafs_cycled/gcdas.20211220/18/obs/gcdas.t18z.viirs_npp_aod.tm00.nc

This reminded me that we need this fix so that the path is /C96_gcafs_cycled/gdas.20211220/18/obs and not /C96_gcafs_cycled/gcdas.20211220/18/obs.

@aerorahul aerorahul merged commit dcc759a into NOAA-EMC:develop Jun 16, 2025
5 checks passed
@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @aerorahul for the quick merge. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JEDI Feature development to support JEDI-based DA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aero_prepobs.py can erroneously set the destination directory for obs files
3 participants