Skip to content

Improve GW forecast timing of high-resolution runs with findings from containerized GW #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2025
Merged

Improve GW forecast timing of high-resolution runs with findings from containerized GW #4123

merged 4 commits into from
Oct 6, 2025

Conversation

weihuang-jedi
Copy link
Contributor

Description

While working on containerized GW, we have found that some network settings will significantly/dramatically improve GW forecast timing at high-resolution. Want to apply those changes to GW before the container code is reviewed.

Resolves #4122

Type of change

  • Bug fix (fixes something broken)
  • [ x] New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

  • C48_S2SW, and C768_S2SW test on Ursa and GaeaC6

Checklist

  • Any dependent changes have been merged and published
  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • [x ] My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@weihuang-jedi weihuang-jedi marked this pull request as ready for review October 2, 2025 20:42
aerorahul
aerorahul approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.
Only thing to test/check here is if these blocks also improve runtime of the GSI, JEDI executables.

@JessicaMeixner-NOAA
Copy link
Contributor

@weihuang-jedi - what is your definition of high resolution in this case?

@weihuang-jedi
Copy link
Contributor Author

I have not run GSI, JEDI before, and from the the tests I did, it improves performance of high-resolution.
Hope someone at GSI, and JEDI group can do some tests with their high-resolution cases.

@JessicaMeixner-NOAA
Copy link
Contributor

While not a clean test because the two runs used different spack-stacks, but using the updates suggested here, the same configuration of C1152 S2SW forecast went from 11433.912819 to 4086.673683 seconds. Thank you @weihuang-jedi !! This is awesome!

@weihuang-jedi
Copy link
Contributor Author

@JessicaMeixner-NOAA Thank you very much for testing it out, and glad to see the similar runtime improvement.

DavidHuber-NOAA
DavidHuber-NOAA approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @weihuang-jedi!

@DavidHuber-NOAA
Copy link
Contributor

DavidHuber-NOAA commented Oct 6, 2025 •
edited
Loading

Launching CI on C6 and Ursa. (EDIT: C6 still needs some spack-stack work).

@emcbot emcbot added CI-Ursa-Ready **CM use only** PR is ready for CI testing on Ursa CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa CI-Ursa-Running **Bot use only** CI testing on Ursa for this PR is in-progress CI-Ursa-Passed **Bot use only** CI testing on Ursa for this PR has completed successfully and removed CI-Ursa-Ready **CM use only** PR is ready for CI testing on Ursa CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa CI-Ursa-Running **Bot use only** CI testing on Ursa for this PR is in-progress labels Oct 6, 2025
@aerorahul aerorahul merged commit b645413 into NOAA-EMC:develop Oct 6, 2025
5 checks passed
weihuang-jedi added a commit to NOAA-EPIC/global-workflow-cloud that referenced this pull request Oct 8, 2025
@weihuang-jedi
Merge branch 'develop' of github.com:NOAA-EPIC/global-workflow-cloud …
958ae08 
…into feature/adjust_tasks_per_node_layout

* 'develop' of github.com:NOAA-EPIC/global-workflow-cloud:
  Update CODEOWNERS for new oceanice_products assignments (NOAA-EMC#4134)
  Improve GW forecast timing of high-resolution runs with findings from containerized GW (NOAA-EMC#4123)
  Update CODEOWNERS to change job assignments (NOAA-EMC#4128)
  Update j-jobs to be bash linter compliant (NOAA-EMC#4124)
  Update the marine analysis archiving (NOAA-EMC#4082)
  Port tracker/genesis tasks to cloud; load wgrib2; add noaacloud to load_gw_gsi_modules (NOAA-EMC#4111)
  Only run wave bnd pnt for gfs (NOAA-EMC#4112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul aerorahul approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA

@DavidBurrows-NCO DavidBurrows-NCO Awaiting requested review from DavidBurrows-NCO

Assignees

No one assigned

Labels

CI-Ursa-Passed **Bot use only** CI testing on Ursa for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve GW performance of high-resolution runs with findings from containerized GW

5 participants

@weihuang-jedi @JessicaMeixner-NOAA @DavidHuber-NOAA @aerorahul @emcbot