Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update soil variables to be consistent with fv3-jedi changes #56

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Dec 13, 2024

When the GDASApp sorc/fv3-jedi hash is updated to 97e10d5 or a hash after this commit, it is necessary, at a minimum, to update soil variables in the following templates

model/atmosphere/atmosphere_background.yaml.j2
model/atmosphere/atmosphere_background_ensemble.yaml.j2

This PR is opened to update the soil variables in the above templates.

Resolves #49

NOTE: GDASApp PR #1377 requires this PR be merged into jcb-gdas develop. Once this is done, the parm/jcb-gdas hash in #1377 should be updated to point at the new jcb-gdas develop.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review December 17, 2024 18:27
@RussTreadon-NOAA RussTreadon-NOAA changed the title update soil variables to be consistent with fv3-jedi changes - DO NOT MERGE update soil variables to be consistent with fv3-jedi changes Dec 17, 2024
@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as draft December 17, 2024 20:19
@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review December 20, 2024 14:25
@danholdaway danholdaway merged commit d750383 into develop Dec 20, 2024
1 check passed
@danholdaway danholdaway deleted the feature/update_soil branch December 20, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update soil variables in atmospheric deterministic and ensemble background templates
2 participants