Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precipitable clouds in microwave all-sky assimilations #63

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

jianjunj
Copy link
Contributor

Add rain, snow, and graupel clouds for CRTM inputs.
Add a prior filter to zero clouds over non-water surfaces.
Add an option of clouds in the Hydrometeo check.
Add gross error check threshold for precipition impacted channels.
Add cold-air-outbreak filters.
Read cloud fraction from GeoVals.
Render list of not-bias corrected channels from JCB tables.
Add configurations for atms_n21.

  Add a prior filter to zero clouds over non-water surfaces.
  Add an option of clouds in the Hydrometeo check.
  Add gross error check threshold for precipition impacted channels.
  Add cold-air-outbreak filters.
  Read cloud fraction from GeoVals.
  Render list of not-bias corrected channels from JCB tables.
  Add configurations for atms_n21.
@jianjunj jianjunj added the draft draft PR often used for discussion label Jan 14, 2025
@danholdaway danholdaway merged commit 875fb3c into develop Jan 16, 2025
1 check passed
@danholdaway danholdaway deleted the feature/microwave_allsky_precipitable_clouds branch January 16, 2025 17:55
@DavidNew-NOAA
Copy link
Contributor

@jianjunj I'm getting an error of "Could not find 'not_biascorrtd' in the variables for observer atms_n20" when running the JEDI atmanlinit job in the Global Workflow. It seems like the error is related to this PR. Do you know how I can fix this error? Is there a GDASApp companion PR associated with this PR?

@jianjunj
Copy link
Contributor Author

@danholdaway It turns out the PR #59 we made in Dec was yet merged. I tended to ask you hold this PR #63 yesterday, but I posted the message in that PR :(. Sorry for the confusion.

@jianjunj
Copy link
Contributor Author

@danholdaway I take it back. Let me take a look.

@jianjunj
Copy link
Contributor Author

@danholdaway I think you need checkout the JCB develop branch in order to have the PR NOAA-EMC/jcb#15 we made in December.

@DavidNew-NOAA
Copy link
Contributor

Thanks, @jianjunj ! I will try that.

@jianjunj
Copy link
Contributor Author

No problem @DavidNew-NOAA. I kept sending messages to Dan. :(

@jianjunj
Copy link
Contributor Author

@DavidNew-NOAA I should not have made this PR since it needs two UFO PRs.
https://github.com/JCSDA-internal/ufo/pull/3573
https://github.com/JCSDA-internal/ufo/pull/3577
So, you may have trouble in running it. Again, my bad.

@DavidNew-NOAA
Copy link
Contributor

DavidNew-NOAA commented Jan 17, 2025

No worries @jianjunj :) We can either make a new PR to revert this one or we can just wait until those UFO PRs are merged and then update the UFO hash in GDASApp when we update the rest of the JEDI hashes. Any thoughts @RussTreadon-NOAA ?

@RussTreadon-NOAA
Copy link
Contributor

@jianjunj , how soon do you expect

to be merged into ufo develop?

@jianjunj
Copy link
Contributor Author

@RussTreadon-NOAA @DavidNew-NOAA It may take some time. I'd suggest we revert it.

@RussTreadon-NOAA
Copy link
Contributor

OK, @jianjunj. We can revert.

@RussTreadon-NOAA RussTreadon-NOAA restored the feature/microwave_allsky_precipitable_clouds branch January 17, 2025 23:12
RussTreadon-NOAA added a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft draft PR often used for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants