Skip to content

Commit

Permalink
Merge pull request #474 from NOAA-FIMS/441-dev-checklist
Browse files Browse the repository at this point in the history
#441: fix reviewer checklist build trigger, edit checklist
  • Loading branch information
k-doering-NOAA authored Oct 5, 2023
2 parents 0faddb0 + 78a2d6a commit 009f763
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/pr-checklist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
name: Add a comment with reviewer checklist when PR opened
on:
pull_request:
types: [ready_for_review]

jobs:
pr-checklist:
Expand Down Expand Up @@ -35,15 +34,11 @@ jobs:
- [ ] The code is well-designed.
- [ ] The functionality is good for the users of the code.
- [ ] Any User Interface changes are sensible and look good.
- [ ] Parallel computing remains functional.
- [ ] The code isn’t more complex than it needs to be.
- [ ] The developer isn’t implementing things they might need in the future but don’t know they need now.
- [ ] Code has appropriate [unit tests](https://noaa-fims.github.io/collaborative_workflow/testing.html#testing).
- [ ] Tests are well-designed.
- [ ] Code coverage remains high, indicating the new code is tested.
- [ ] The developer used clear names for everything.
- [ ] Comments are clear and useful, and mostly explain why instead of what.
- [ ] Code is appropriately documented (doxygen and roxygen).
- [ ] The code conforms to our [style guides](https://noaa-fims.github.io/collaborative_workflow/contributor-guidelines.html#style-guide).
`
const { issue: { number: issue_number }, repo: { owner, repo } } = context;
github.issues.createComment({ issue_number, owner, repo, body: msg });

0 comments on commit 009f763

Please sign in to comment.