-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor (*.R): Adhere to tidyverse principals
by cleaning up the R code Removes functions * mkObj * create_rcpp_interface_object * use_module * %>% * FIMSFrameAge Adds importFrom(TMB, MakeADFun) to package b/c TMB is no longer explicitly used in the codebase. And, experimented with removing usethis b/c it was also used in ./R/ but is still used in data-raw. It is now a suggested package. Uses :: instead of importing functions, e.g., utils::head(). * Constricts line width to 80 characters * Use full stops at the end of sentences * Implement more spacing in between roxygen tags * Move export tag to the end in most instances * Use explicit brackets for if statements * Remove duplicated code in gtest by calling run_gtest() * Parameter and object names to snake_case * Parameter, function, and object names, largely, w/o abbreviations fix(run_gtest): Use paste() instead of paste0() to ensure proper spacing which is not explicit in the instructions. With paste() they can input as many additional arguments as they want and they are all automatically separated, e.g., `run_gtest("--something", "--something-else")` Close #588 Close #564 Close #590
- Loading branch information
1 parent
fe5836b
commit 2431f59
Showing
35 changed files
with
245 additions
and
814 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.