-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename testthat files #571
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made two comments about the file names but other than that everything looks good to merge this into main tomorrow.
@k-doering-NOAA I made two comments on this PR that I am not entirely sure if they are valid or not. Once those are addressed we can merge it in. |
@kellijohnson-NOAA sorry this took so long - I just replied to your comments. Feel free to decide based on my comments if the changes should be made and merge it in when ready (Or, I'm happy to make the changes if you prefer, just let me know what you think makes sense)! |
To make it clear this is an integration test.
08ef0e2
to
38a49c3
Compare
What is the feature?
How have you implemented the solution?
This includes:
test-name_of_r_file.R
test-rcpp-description.R
(wheredescription
describes the interface being tested.test-integration-description.R
(wheredescription
describes the integration test).Does the PR impact any other area of the project?
How to test this change
Make sure GitHub actions are passing and that filenames are as described
Developer pre-PR checklist