-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proportion female #654
Conversation
add tests to ParameterVector add tests for constructors passing unit tests for ParameterVector add more test cases for ParameterVector add documentation
issue #170: refactor distributions_base issue #581: add lognormal_lpdf issue #573: add normal_lpdf issue #585 add multinomial_lpmf rename SIMULATE_F to FIMS_SIMULATE_F rename REPORT_F to FIMS_REPORT_F Co-authored-by: Matthew-Supernaw-NOAA <matthew.supernaw@noaa.gov> Co-authored-by: Christine Stawitz - NOAA <ChristineStawitz-NOAA@users.noreply.github.com>
issue #388 convert tests to testthat format in: test-unit-rcpp-interface-variable-vector.R update name of ParameterVector id to id_m fix parameter order warning update Rcpp class documentation refactor operators -collapses methods using S4 Group Generic Functions -define methods for Ops, Math, and Summary -update roxygen methods documentation add fill_min and fill_max to ParameterVector update parameter min/max default values
* issue #586 * link new densities to fleet * modify interface * fix bugs * modify tests * modify nll call in recruitment * fix recruit eval nll * add conditional is_na and comment out report * move tmb pointer here * fix warnings * bug fix * fix segfault issue * fix nll summing bug * add macros * fix interface * fix tests * fix tmb distributions test - now passing * delete tmb_distributions * Add more normal tests cases -- failing still * fix observed_values loop * fix tests and add lognormal test and dimension check * comment out dimension mismatch error check --------- Co-authored-by: Matthew-Supernaw-NOAA <matthew.supernaw@noaa.gov> Co-authored-by: Christine Stawitz - NOAA <ChristineStawitz-NOAA@users.noreply.github.com> Co-authored-by: Cole-Monnahan-NOAA <cole.monnahan@noaa.gov> Co-authored-by: Chris Legault <chris.legault@noaa.gov> Co-authored-by: KyleShertzer-NOAA <KyleShertzer-NOAA@users.noreply.github.com>
* issue #630 * update documentation style
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
24a5457
to
fb13fe5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
===========================================
- Coverage 78.88% 66.06% -12.82%
===========================================
Files 36 19 -17
Lines 1975 725 -1250
Branches 141 196 +55
===========================================
- Hits 1558 479 -1079
+ Misses 374 165 -209
- Partials 43 81 +38 ☔ View full report in Codecov by Sentry. |
0a82bcb
to
8995cd6
Compare
Users thought that they could set proportion_female but it was hard- coded to 0.5 on the back end. Now, it is back to just being a single value that is hard coded to 0.5. Tests have also changed back to 0.5. This partially reverts PR #543. And, was talked about in NOAA-FIMS/seaside-chats#7 and partially addresses #638.
8995cd6
to
577a68b
Compare
Now in cleanup_dev branch to be brought into dev. |
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?