[Build | CI] Python 3 12 support#374
Conversation
|
Approved pending CI passes |
romanc
left a comment
There was a problem hiding this comment.
PR looks good to me. Required GHA checks are done by name. And since this name changed, this PR will be stuck until that requirement is fullfilled (or the restriction is lifted). I suggest diabling the "ndsl unit test" requirements temporarily. In the long run, we probably want to change blocking CI to have a skngle entey point such that we can change what is blocking without access to the repo's admin settings (where this is currently configured).
Poke @fmalatino can you deactivate the requirements of "ndsl unit test" please? We don't have access. |
|
Now that this PR is merged, @fmalatino can you make sure that NDSL unit tests @ python 3.11 and 3.12 are both required for merge again?
Thanks! 🙏 |
It should be now. Let me know if it does not appear on your end. |
@fmalatino, It still looks the same on my side (e.g. in PRs #377 and #372)
This needs to be configured in the admin settings of the repo where I don't have access to. It's part of the branch protection rules. Here's a screenshot (from another repo) what to look out for
in that list of "Status checks that are required" you should see the old one, which needs to be removed. And in the same list, you can add the new ones (there are now two new ones, one for python 3.11 and one for python 3.12). Those should be required and thus added to the list. |
Please let me know if they appear correct now. |
It all looks good now. PRs proceed to the merge queue. Thanks! |






Description
Python 3.12 support was locked behind a leaking of
thread_localvariable. It was followed back all the way to apybind11issue with3.xversions. GT4Py is now limiting to the use ofpybind11to2.x.Now cleared out of this bug,
gt4pyanddacealready support and run3.12as part of their CI. We do not expect issues with NDSL.This PR updates the maximum python version to 3.12 and change the NDSL unit tests to be run on both versions.
Also:
Kquery in thenumpybackend to NDSL.How has this been tested?
Let the CI be the judge !