WIP Dev catfim v2 1 alaska #1300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dev-catfim-v2-1
…ion-mapping into dev-catfim-v2-1
groutr
reviewed
Nov 5, 2024
| @@ -288,7 +288,7 @@ def merge_log_files(self, parent_log_output_file, file_prefix, remove_old_files= | |||
| # ------------------------------------------------- | |||
| def trace(self, msg): | |||
| # goes to file only, not console | |||
| level = "TRACE " # keeps spacing the same | |||
| level = "TRACE " # keeps spacing the same (9 chars wide) | |||
There was a problem hiding this comment.
A cleaner way to do this is level = "TRACE".ljust(9)
There was a problem hiding this comment.
Love it. I will duplicate that with the rest of my logging level types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Additions
Changes
Removals
Testing
Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>devbranch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>(e.g.dev-revise-levee-masking)devbranchpre-commithooks were run locally4.x.x.xMerge Checklist (For Technical Lead use only)